-
Notifications
You must be signed in to change notification settings - Fork 0
Add simple safeguarded compressor wrappers for BitRound, ZFP, SZ3, and SPERR #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
@treigerm The safeguards have their first public alpha release on PyPi now, so this is ready for our debugging session tomorrow |
|
@treigerm This is now ready again, please completely remove the |
|
Also, please include all safeguarded compressors (safeguarded-bitround-pco, safeguarded-zfp-round, safeguarded-sz3, safeguarded-sperr, safeguarded-zero, safeguarded-zero-dssim). Thanks! |
|
While the Safeguarded(0, dSSIM) compressor works as expected on 2D data, it fails once we have different height levels, since analysis quantises over the 2D min-max range, but the safeguards are only given the global ones. This could be done by threading through the per-2D level range ... let's see if I can make it work |
This PR adds (simple) safeguarded (https://github.com/juntyr/compression-safeguards) variants for the BitRound+PCO, ZFP-ROUND, SZ3, and SPERR compressors