fix compatibility between hardening and asan#69
Merged
mstetsyuk merged 1 commit intoClickHouse/release-21.xfrom Jan 26, 2026
Merged
fix compatibility between hardening and asan#69mstetsyuk merged 1 commit intoClickHouse/release-21.xfrom
mstetsyuk merged 1 commit intoClickHouse/release-21.xfrom
Conversation
thevar1able
approved these changes
Jan 23, 2026
Member
thevar1able
left a comment
There was a problem hiding this comment.
LGTM, let's upstream this change?
Member
|
Yes, this ^^ |
Member
Author
I will do that asynchronously with merging this PR, so that this effort doesn't get blocked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the PR where I enabled the hardening, there's an ASan error which is consistent and unique to the PR, see cidb).
It occurs in unique_ptr code:
because
__in_boundsreads array cookie directly from memory which is marked as poisoned by the sanitizer.That should be read via
__asan_load_cxx_array_cookie(code) instead as it checks if the memory is marked askAsanArrayCookieMagicand if so, just returns the cookie.