v0.13.0 release

docs/source/changelog.rst

@@ -8,6 +8,20 @@ The page attempt to keep a clear list of breaking/non-breaking changes and new f
    :local:
    :backlinks: none
 
+v0.13.0
+-----------
+Bug Fixes
+###########
+* Renamed `base.search` `category` parameter to `search_category` to avoid conflict with filters
+* Fixed the way IDs are retrieved
+* Fixed a bug where saving files and medias would not stream the response
+* Fixed issue where the front page would sometimes fail to parse
+
+New Features
+##############
+* `File` and `Addon` now have a `location` value that contains the location list of the entity
+* `File.save`, `Addon.save` and `Media.save` can now take `chunk_size` as a keyword parameter to define the size of the chunks to stream in
+
 v0.12.0
 -------
 Bug Fixes

docs/source/conf.py

@@ -27,7 +27,7 @@
 # The short X.Y version
 version = ""
 # The full version, including alpha/beta/rc tags
-release = "0.12.0"
+release = "0.13.0"
 
 
 # -- General configuration ---------------------------------------------------

moddb/__init__.py

@@ -9,7 +9,7 @@
 SESSION = requests.Session()
 SESSION.mount("https://", SSLAdapter())
 
-__version__ = "0.12.0"
+__version__ = "0.13.0"
 
 __all__ = [
     "front_page",

moddb/base.py

@@ -17,7 +17,7 @@
 
 
 def search(
-    category: SearchCategory,
+    search_category: SearchCategory,
     *,
     query: str = None,
     sort: Tuple[str, str] = None,
@@ -35,7 +35,7 @@ def search(
 
     Parameters
     ------------
-    category : SearchCategory
+    search_category : SearchCategory
         The model type that you want to search
     query : str
         String to search for in the model title
@@ -58,7 +58,7 @@ def search(
     game = filters.get("game", None)
     game = game.id if game else None
 
-    url = f"{BASE_URL}/{category.name}/page/{page}"
+    url = f"{BASE_URL}/{search_category.name}/page/{page}"
     filter_parsed = {key: value.value for key, value in filters.items() if hasattr(value, "value")}
 
     params = {
@@ -82,7 +82,7 @@ def search(
         total_pages=total_pages,
         current_page=current_page,
         params=params,
-        url=f"{BASE_URL}/{category.name}",
+        url=f"{BASE_URL}/{search_category.name}",
         total_results=total_results,
     )
 

moddb/boxes.py

@@ -5,8 +5,9 @@
 import logging
 import re
 import sys
-from typing import TYPE_CHECKING, Any, List, Tuple, Union
+from typing import TYPE_CHECKING, Any, Generic, List, Tuple, TypeVar
 
+from typing_extensions import Self
 from bs4 import BeautifulSoup
 
 from .enums import (
@@ -1072,8 +1073,9 @@ def __init__(self, **kwargs):
     def __repr__(self):
         return f"<Option text={self.text}>"
 
+T = TypeVar('T')
 
-class ModDBList(collections.abc.MutableSequence):
+class ModDBList(collections.abc.MutableSequence[T], Generic[T]):
     """Base List type for the lib
 
     Attributes
@@ -1087,8 +1089,8 @@ class ModDBList(collections.abc.MutableSequence):
     """
 
     def __init__(self, **kwargs):
-        self._results = kwargs.pop("results")
-        self._params = kwargs.pop("params", {})
+        self._results: List[T] = kwargs.pop("results")
+        self._params: dict = kwargs.pop("params", {})
         self._url = kwargs.pop("url")
         self.total_pages = kwargs.pop("total_pages")
         self.current_page = kwargs.pop("current_page")
@@ -1113,13 +1115,13 @@ def _do_request(self, **kwargs):
             total_results=total_results,
         )
 
-    def next_page(self) -> Union["ResultList", "CommentList"]:
+    def next_page(self) -> Self:
         """Returns the next page of results as either a CommentList if you are retriving comments or
         as a ResultList if it's literally anything else.
 
         Returns
         --------
-        Union[ResultList, CommentList]
+        Self
             The new search objects containing a new set of results.
 
         Raises
@@ -1132,13 +1134,13 @@ def next_page(self) -> Union["ResultList", "CommentList"]:
 
         return self.to_page(self.current_page + 1)
 
-    def previous_page(self) -> Union["ResultList", "CommentList"]:
+    def previous_page(self) -> Self:
         """Returns the previous page of results as either a CommentList if you are retriving comments or
         as a ResultList if it's literally anything else.
 
         Returns
         --------
-        Union[ResultList, CommentList]
+        Self
             The new list-like object of results.
 
         Raises
@@ -1151,7 +1153,7 @@ def previous_page(self) -> Union["ResultList", "CommentList"]:
 
         return self.to_page(self.current_page - 1)
 
-    def to_page(self, page: int) -> Union["ResultList", "CommentList"]:
+    def to_page(self, page: int) -> Self:
         """Returns the desired page of results as either a CommentList if you are retriving comments or
         as a ResultList if it's literally anything else.
 
@@ -1162,7 +1164,7 @@ def to_page(self, page: int) -> Union["ResultList", "CommentList"]:
 
         Returns
         --------
-        Union[ResultList, CommentList]
+        Self
             The new list-like object of results.
 
         Raises
@@ -1175,7 +1177,7 @@ def to_page(self, page: int) -> Union["ResultList", "CommentList"]:
 
         return self._do_request(page=page)
 
-    def get_all_results(self):
+    def get_all_results(self) -> Self:
         """An expensive methods that iterates over every page of the result query and returns all
         the results. This may return more results than you expected if new page have fit the criteria
         while iterating.
@@ -1206,26 +1208,26 @@ def key(element):
         search._results = list({key(e): e for e in results}.values())
         return search
 
-    def __repr__(self):
+    def __repr__(self) -> str:
         return f"<{self.__class__.__name__} pages={self.current_page}/{self.total_pages}, results={self._results}>"
 
-    def __getitem__(self, element):
-        return self._results.__getitem__(element)
+    def __getitem__(self, index: int) -> T:
+        return self._results.__getitem__(index)
 
-    def __delitem__(self, element):
-        self._results.__delitem__(element)
+    def __delitem__(self, index: int):
+        self._results.__delitem__(index)
 
-    def __len__(self):
+    def __len__(self) -> int:
         return self._results.__len__()
 
-    def __setitem__(self, key, value):
+    def __setitem__(self, key: int, value: T):
         self._results.__setitem__(key, value)
 
-    def insert(self, index, value):
+    def insert(self, index: int, value: T):
         self._results.insert(index, value)
 
 
-class ResultList(ModDBList):
+class ResultList(ModDBList[Thumbnail]):
     """Represents a list of result gotten from one of the many get methods the library uses. This is returned
     over a regular list because it has additional methods that allow for easily go through all the results. In
     the same way that the moddb site works, you don't have to re-run the query manually to get the next page,
@@ -1246,7 +1248,7 @@ class ResultList(ModDBList):
     def _parse_method(self, html: BeautifulSoup):
         return _parse_results(html)
 
-    def resort(self, new_sort: Tuple[str, str]) -> "ResultList":
+    def resort(self, new_sort: Tuple[str, str]) -> Self:
         """Allows you to sort the whole search by a new sorting parameters. Returns a new search object.
 
         Parameters
@@ -1261,11 +1263,11 @@ def resort(self, new_sort: Tuple[str, str]) -> "ResultList":
         """
         return self._do_request(sort=f"{new_sort[0]}-{new_sort[1]}")
 
-    def __contains__(self, element):
+    def __contains__(self, element: Thumbnail) -> bool:
         return get(self._results, name=element.name) is not None
 
 
-class CommentList(ModDBList):
+class CommentList(ModDBList[Comment]):
     """Represents a list of comments. This emulates a list and will behave like one, so you
     can use any of the regular list operators in addition to the methods defined below.
 
@@ -1282,7 +1284,7 @@ class CommentList(ModDBList):
     def _parse_method(self, html: BeautifulSoup):
         return _parse_comments(html)
 
-    def __contains__(self, element):
+    def __contains__(self, element: Comment) -> bool:
         return get(self._results, name=element.name) is not None
 
     def flatten(self) -> List[Comment]:

moddb/pages/base.py

@@ -52,16 +52,26 @@ def __init__(self, html: BeautifulSoup):
             except AttributeError:
                 self.name = html.find("meta", property="og:title")["content"]
 
-        try:
-            self.id = int(
-                re.search(r"siteareaid=(\d*)", html.find("a", class_=["reporticon"])["href"])[1]
-            )
-        except TypeError:
+        for index, func in enumerate(
+            [
+                lambda: int(
+                    re.search(r"siteareaid=(\d*)", html.find("a", class_=["reporticon"])["href"])[1]
+                ),
+                lambda: int(html.find("input", attrs={"name": "siteareaid"})["value"]),
+                lambda: int(html.find("meta", property="og:image")["content"].split("/")[-2]),
+                lambda: re.match(
+                    r"https:\/\/www\.moddb\.com\/html\/scripts\/autocomplete\.php\?a=mentions&p=home&l=6&u=(\d*)",
+                    str(html),
+                ).group(1),
+            ]
+        ):
             try:
-                self.id = int(html.find("input", attrs={"name": "siteareaid"})["value"])
+                self.id = func()
+                break
             except (AttributeError, TypeError):
-                # really scratching the bottom here but a lot of "official" groups don't have the regular ID
-                self.id = int(html.find("meta", property="og:image")["content"].split("/")[-2])
+                LOGGER.warning("Failed to get id from method %s for member %s", index, self.name)
+        else:
+            raise AttributeError(f"Failed to get id from member {self.name}")
 
         try:
             self.url = html.find("meta", property="og:url")["content"]
@@ -72,7 +82,7 @@ def __init__(self, html: BeautifulSoup):
 
         try:
             self.report = join(html.find("a", string="Report")["href"])
-        except TypeError:
+        except (TypeError, AttributeError):
             self.report = None
             LOGGER.info(
                 "'%s' '%s' cannot be reported",