file-location adding file locations#60
Merged
ClementJ18 merged 7 commits intodevelopfrom May 20, 2025
Merged
Conversation
ClementJ18
commented
May 18, 2025
|
See my comment on #61; additionally, though, even if this isn't ready yet, could it still be used okay? Just asking since even if it would be i.e 12 or 24 hours before this PR is fully finished, it would make a big difference to me if I could still start using it now. Also, how would I get a file's game name with this PR now? Do i have to check [file].location[0] == "Games", then retrieve [file].location[1]? |
Owner
Author
|
You can probably use this branch, I don't think I'll make any big changes. Location is a list of thumbnail, so you can iterate over and check the thumbnail type until you get to a game one. https://moddb.readthedocs.io/en/stable/boxes.html#moddb.boxes.Thumbnail.type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #59