Add Ctrl+B keyboard shortcut to toggle sidebar visibility from arturhg (#213) #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented toggleSideBarsVisibility() method in SideBar.java - Added toggleVisibility() method to handle individual sidebar toggling - Registered Ctrl+B (Cmd+B on Mac) shortcut in KeyboardShortcuts.java - Added translation keys for English, French, and Italian - Documentation update will be needed in ODT and PDF files Fixes #206
- Changed approach to set sidebar width to 0 instead of removing it from the pane - This allows users to manually resize the sidebar back if needed - Added savedWidth field to store and restore the original sidebar width - Fixes ArrayIndexOutOfBoundsException when toggling with only one sidebar - Fixes width restoration issue when toggling right sidebar
- Added new View menu to the menu bar - Implemented Toggle Sidebars (Ctrl+B) to show/hide both sidebars - Added Restore Default Sidebar Width option - Added Minimize Sidebars option to collapse to minimum width - Added Move All Tabs to Left/Right for quick reorganization - Fixed ArrayIndexOutOfBoundsException when last sidebar is removed - Changed minimum sidebar width from 0 to 1 pixel to avoid GTK warnings on Linux - Added helper methods for sidebar manipulation (moveAllTabsToLeft/Right, restoreDefaultWidth, minimizeWidth) - Added translations for all new menu items in English, French, and Italian Addresses feedback from PR review: - Sidebars now collapse to minimal width instead of being removed from pane - Prevents users from getting stuck if they forget the shortcut - Adds menu discoverability for the Ctrl+B shortcut - Groups all sidebar-related actions in one menu
- Fix sidebar toggle to set width to 1px instead of removing from pane - Remove sidebars completely when all tabs are moved to other side - Remove duplicate keyboard shortcut for sidebar toggle on macOS - Add View menu with sidebar management options - Move fullscreen from Tools to View menu - Add platform-specific fullscreen shortcuts (Cmd+Ctrl+F on macOS, F11 elsewhere) - Make View menu items reactive (disable when not applicable) - Add dynamic fullscreen text switching between Enter/Exit Full Screen - Clean up old Tools menu fullscreen translations
…ic text updates in menu - Updated dynamic sidebar toggle text based on state. - Enhanced Italian, French, and English translations for sidebar-related menu items.
- Implemented toggleSideBarsVisibility() method in SideBar.java - Added toggleVisibility() method to handle individual sidebar toggling - Registered Ctrl+B (Cmd+B on Mac) shortcut in KeyboardShortcuts.java - Added translation keys for English, French, and Italian - Documentation update will be needed in ODT and PDF files Fixes #206
- Changed approach to set sidebar width to 0 instead of removing it from the pane - This allows users to manually resize the sidebar back if needed - Added savedWidth field to store and restore the original sidebar width - Fixes ArrayIndexOutOfBoundsException when toggling with only one sidebar - Fixes width restoration issue when toggling right sidebar
- Added new View menu to the menu bar - Implemented Toggle Sidebars (Ctrl+B) to show/hide both sidebars - Added Restore Default Sidebar Width option - Added Minimize Sidebars option to collapse to minimum width - Added Move All Tabs to Left/Right for quick reorganization - Fixed ArrayIndexOutOfBoundsException when last sidebar is removed - Changed minimum sidebar width from 0 to 1 pixel to avoid GTK warnings on Linux - Added helper methods for sidebar manipulation (moveAllTabsToLeft/Right, restoreDefaultWidth, minimizeWidth) - Added translations for all new menu items in English, French, and Italian Addresses feedback from PR review: - Sidebars now collapse to minimal width instead of being removed from pane - Prevents users from getting stuck if they forget the shortcut - Adds menu discoverability for the Ctrl+B shortcut - Groups all sidebar-related actions in one menu
- Fix sidebar toggle to set width to 1px instead of removing from pane - Remove sidebars completely when all tabs are moved to other side - Remove duplicate keyboard shortcut for sidebar toggle on macOS - Add View menu with sidebar management options - Move fullscreen from Tools to View menu - Add platform-specific fullscreen shortcuts (Cmd+Ctrl+F on macOS, F11 elsewhere) - Make View menu items reactive (disable when not applicable) - Add dynamic fullscreen text switching between Enter/Exit Full Screen - Clean up old Tools menu fullscreen translations
…ic text updates in menu - Updated dynamic sidebar toggle text based on state. - Enhanced Italian, French, and English translations for sidebar-related menu items.
…-sidebars # Conflicts: # src/main/java/fr/clementgre/pdf4teachers/utils/VersionIds.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the changes of #213 with upgraded behavior, production-ready.