Skip to content

Conversation

@Ecdcaeb
Copy link
Contributor

@Ecdcaeb Ecdcaeb commented Feb 24, 2024

Fix MinecraftForge/MinecraftForge#5092
and provide a new event which enable register/unregister factories;

Why I could not use _factories.json to define it? But a event?

Of course you can use json, but using events is more dynamic, without reflection, and suitable for mods with missing resources.

Why dynamic registration is needed

There is currently no way to selectively register Json, and the conditional syntax designed by Forge for Json cannot be used on it. When I create a Factory for a optional dependency, however, I have to mark it as a required-dependency.

When will resources be missing?

Coremod,or the broken env.

@Ecdcaeb Ecdcaeb changed the title CraftingFactoriesRegisterEvent & Allow for actual Resource Locations [5092]CraftingFactoriesRegisterEvent & Allow for actual Resource Locations May 2, 2024
@Ecdcaeb Ecdcaeb changed the title [5092]CraftingFactoriesRegisterEvent & Allow for actual Resource Locations [5092] CraftingFactoriesRegisterEvent & Allow for actual Resource Locations May 4, 2024
@Rongmario Rongmario added the proposal pending This pull request is waiting on a proposal to be written up label Apr 4, 2025
@Ecdcaeb Ecdcaeb mentioned this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proposal pending This pull request is waiting on a proposal to be written up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1.12.2] Registering Crafting Condition Factories does not allow for actual Resource Locations

2 participants