Enable NetworkCheckerHandler to use updated String methods #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
What's the purpose of this |
Contributor
Author
The old method returned a boolean, and as you can see, its internal method has been deprecated. This PR just turns on this feature, and does not add anything. In fact, this method was originally inaccessible (this deprecation is meaningless(x |
Collaborator
|
Should mention that in comment |
Collaborator
|
Should mention that in comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old method returned a boolean, and as you can see, its internal method has been deprecated.
boolean check(Map, Side)->String checkCompatible(Map, Side)The new method returns a String, which means that custom incompatibility information can be provided.
This PR just turns on this feature, and does not add anything.
In fact, this method was originally inaccessible (this deprecation is meaningless(x