Dev

src/app/controller/admin_controller.py

@@ -274,9 +274,10 @@
     request: Request,
     skip: int = Query(0, ge=0, description="Number of records to skip"),
     limit: int = Query(10, ge=1, le=100, description="Max records to return"),
+    email: str = Query(None, description="Filter admins by email"),
 ):
     """
     Retrieve all admins from the database. Requires admin session.
     """
     service.get_current_session_admin(request)
-    return service.get_admins(skip=skip, limit=limit)
+    return service.get_admins(skip=skip, limit=limit, email=email)

src/app/service/admin_service.py

@@ -11,7 +11,6 @@
 
 from app.db.db import db
 from app.models.admin import AdminCreate, AdminLogin
-from app.schemas.admins import admins_entity
 
 logger = logging.getLogger(__name__)
 
@@ -94,10 +93,16 @@
 
         return session["email"]
 
-    def get_admins(self, skip: int = 0, limit: int = 10):
-        admins = admins_entity(self.admins_collection.find().skip(skip).limit(limit))
-        logger.info(f"[SUCCESSFUL] GET: get_admins.\n\tFetched {len(admins)} admins.")
-        total = self.admins_collection.count_documents({})
+    def get_admins(self, skip=0, limit=10, email=None):
+        query = {}
+        if email:
+            query["email"] = {"$regex": email, "$options": "i"}  # busqueda no-exacta
+        admins_cursor = self.admins_collection.find(query).skip(skip).limit(limit)
+        admins = []
+        for admin in admins_cursor:
+            admin["_id"] = str(admin["_id"])  # <- conversión
+            admins.append(admin)
+        total = self.admins_collection.count_documents(query)
         return {"total": total, "admins": admins}
 
     @staticmethod

tests/unit/test_rule_service.py

@@ -3,6 +3,7 @@
 
 import pytest
 from bson import ObjectId
+from fastapi import HTTPException
 
 from app.models.rule import Rule
 from app.service.rule_service import RuleService
@@ -98,6 +99,21 @@ def test_save_new_rule(mock_conn, sample_rule, sample_rule_dict):
     mock_conn.find_one.assert_called_once_with({"_id": inserted_id})
 
 
+def test_save_rule_invalid_date_raises(mock_conn):
+    past_date = (datetime.now() - timedelta(days=1)).date()
+    rule = Rule(
+        title="Invalid Rule",
+        description="",
+        effectiveDate=past_date,
+        conditions=[],
+    )
+    service = RuleService()
+    with pytest.raises(HTTPException) as exc_info:
+        service.save_rule(rule, "test@email.com", "test_token")
+    assert exc_info.value.status_code == 400
+    assert "effective date must be after today" in str(exc_info.value.detail).lower()
+
+
 def test_get_rule_success(mock_conn, sample_rule_dict):
     rule_id = str(sample_rule_dict["_id"])
     mock_conn.find_one.return_value = sample_rule_dict
@@ -135,6 +151,24 @@ def test_update_rule_success(mock_conn, sample_rule, sample_rule_dict):
     )
 
 
+def test_update_rule_invalid_date_raises(mock_conn, sample_rule_dict):
+    # Fecha pasada (ayer)
+    past_date = (datetime.now() - timedelta(days=1)).date()
+    rule_id = str(sample_rule_dict["_id"])
+    rule = Rule(
+        title="Invalid Rule",
+        description="",
+        effectiveDate=past_date,
+        conditions=[],
+    )
+    mock_conn.find_one.return_value = sample_rule_dict
+    service = RuleService()
+    with pytest.raises(HTTPException) as exc_info:
+        service.update_rule_by_id(rule_id, rule, "test@email.com", "test_token")
+    assert exc_info.value.status_code == 400
+    assert "effective date must be after today" in str(exc_info.value.detail).lower()
+
+
 def test_delete_rule_success(mock_conn, sample_rule_dict):
     rule_id = str(sample_rule_dict["_id"])
     mock_conn.find_one_and_delete.return_value = sample_rule_dict