version: 7.1.10

nova/core/galaxy.yml

@@ -1,6 +1,6 @@
 namespace: nova
 name: core
-version: 6.10.17
+version: 7.1.10
 readme: README.md
 authors:
   - https://github.com/novateams

nova/core/roles/accounts/tasks/routeros.yml

@@ -13,7 +13,7 @@
     ansible_deployer_password: "{{ admin_accounts_with_password
       | selectattr('username', 'equalto', ansible_deployer_username) | map(attribute='password') | first }}"
 
-- name: Adding RSA ssh key for following users...
+- name: Adding ssh key for following users...
   community.routeros.command:
     commands:
       - /file print file=ssh_user_key_{{ item.username }}.txt
@@ -23,9 +23,7 @@
   loop: "{{ admin_accounts_with_password }}"
   loop_control:
     label: "{{ item.username }}"
-  when:
-    - item.ssh_key is defined
-    - item.ssh_key is search("ssh-rsa") # Because EC is not supported
+  when: item.ssh_key is defined
 
 # Required because of RouterOS SSH MaxAuthTries default is too small
 - name: Allowing password login...

nova/core/roles/caddy/tasks/main.yml

@@ -18,6 +18,7 @@
   community.docker.docker_compose_v2:
     project_src: "{{ caddy_config_folder }}"
     state: present
+    build: never
     wait: true
 
 - name: Formatting Caddyfile...
@@ -31,6 +32,7 @@
   community.docker.docker_compose_v2:
     project_src: "{{ caddy_config_folder }}"
     state: restarted
+    build: never
     wait: true
 
 - name: Including Caddyfile API configuration tasks...

nova/core/roles/configure_networking/defaults/main.yml

@@ -98,10 +98,15 @@ configure_networking_panos_boot_wait_time: 60
 # Proxmox #
 ###########
 
+# How many seconds to wait for different networking configuration commands to complete over the Qemu Guest Agent
+# Increasing this may help on slower systems or when Windows is running sysprep on first boot
+# There's a separate timeout command for waiting that the command sent over the guest agent has completed called - configure_networking_command_wait_timeout
+configure_networking_proxmox_timeout: 300
+
 # This is a list of interfaces to exclude when configuring networking on Proxmox VMs
 # These are typically non-physical interfaces like loopback
 configure_networking_proxmox_interfaces_to_exclude:
-  - lo
+  - lo # Linux loopback
   - lo0 # OPNsense loopback
   - enc0 # OPNsense encryption
   - pfsync0 # OPNsense pfsync

nova/core/roles/configure_networking/tasks/proxmox/command_run_check.yml

@@ -1,8 +1,8 @@
 ---
 - name: Verifying that the previous command was successful...
   ansible.builtin.uri:
-    url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-      }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid
+    url:
+      "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid
       }}/agent/exec-status?pid={{ network_config_command.json.data.pid }}"
     headers:
       Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}

nova/core/roles/configure_networking/tasks/proxmox/interfaces.yml

@@ -37,8 +37,7 @@
       block:
         - name: Writing following configuration to {{ custom_vm_name | default(vm_name) }}...
           ansible.builtin.uri:
-            url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-              }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/file-write"
+            url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/file-write"
             headers:
               Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
             method: POST
@@ -64,8 +63,7 @@
 
         - name: Rebuilding initramfs on {{ custom_vm_name | default(vm_name) }}...
           ansible.builtin.uri:
-            url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-              }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/exec"
+            url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/exec"
             headers:
               Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
             method: POST

nova/core/roles/configure_networking/tasks/proxmox/main.yml

@@ -22,8 +22,11 @@
         configure_networking_mac_addresses:
           "{{ proxmox_vm_info.proxmox_vms[0].network | map(attribute='hardware-address', default='00:00:00:00:00:00')
           | reject('equalto', '00:00:00:00:00:00') | list }}"
-        configure_networking_hw_interfaces: "{{ proxmox_vm_info.proxmox_vms[0].network | map(attribute='name')
+        configure_networking_hw_interfaces:
+          "{{ proxmox_vm_info.proxmox_vms[0].network | map(attribute='name')
           | reject('in', configure_networking_proxmox_interfaces_to_exclude) | list }}"
+        cfg_net_proxmox_node: "{{ proxmox_vm_info.proxmox_vms[0].node }}"
+        cfg_net_proxmox_vmid: "{{ proxmox_vm_info.proxmox_vms[0].vmid }}"
 
     - name: Checking if network customization method exists...
       ansible.builtin.stat:

nova/core/roles/configure_networking/tasks/proxmox/netplan.yml

@@ -17,8 +17,7 @@
 
     - name: Removing any existing netplan configurations...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/exec"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/exec"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST
@@ -36,8 +35,7 @@
 
     - name: Writing netplan configuration to {{ custom_vm_name | default(vm_name) }}...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/file-write"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/file-write"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST
@@ -50,8 +48,7 @@
 
     - name: Fixing permissions on netplan configuration file...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/exec"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/exec"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST
@@ -69,8 +66,7 @@
 
     - name: Applying netplan...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/exec"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/exec"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST

nova/core/roles/configure_networking/tasks/proxmox/networkd.yml

@@ -5,8 +5,7 @@
   block:
     - name: Removing any existing network configurations...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/exec"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/exec"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST
@@ -44,8 +43,7 @@
 
     - name: Writing networkd configuration to {{ custom_vm_name | default(vm_name) }}...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/file-write"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/file-write"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST
@@ -81,8 +79,7 @@
 
     - name: Writing networkd links to {{ custom_vm_name | default(vm_name) }}...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/file-write"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/file-write"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST
@@ -98,8 +95,7 @@
 
     - name: Starting networkd & udev services...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/exec"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/exec"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST
@@ -130,8 +126,7 @@
 
     - name: Writing resolv.conf to {{ custom_vm_name | default(vm_name) }}...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/file-write"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/file-write"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST
@@ -144,9 +139,7 @@
 
     - name: Getting OS type...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid
-          }}/agent/file-read?file=/etc/os-release"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/file-read?file=/etc/os-release"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: GET
@@ -169,7 +162,7 @@
       block:
         - name: Configuring network interface(s) names on Debian...
           ansible.builtin.uri:
-            url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/exec"
+            url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/exec"
             headers:
               Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
             method: POST
@@ -190,7 +183,7 @@
           block:
             - name: Getting DNS from DHCP...
               ansible.builtin.uri:
-                url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/exec"
+                url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/exec"
                 headers:
                   Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
                 method: POST
@@ -211,7 +204,7 @@
       block:
         - name: Configuring network interface(s) names on Arch...
           ansible.builtin.uri:
-            url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/exec"
+            url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/exec"
             headers:
               Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
             method: POST

nova/core/roles/configure_networking/tasks/proxmox/nmcli.yml

@@ -3,6 +3,39 @@
   become: false
   delegate_to: localhost
   block:
+    - name: Getting OS...
+      ansible.builtin.uri:
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/file-read?file=/etc/os-release"
+        headers:
+          Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
+        method: GET
+        validate_certs: "{{ proxmox_validate_certs }}"
+      register: network_config_os
+
+    # Check if root is mounted read-only and remount as read-write
+    # This an issue specific to Kali where sometimes root is mounted read-only
+    # Done here because the check needs to happen in the very early stage of the boot
+    - name: Remounting Kali root filesystem as read-write if needed...
+      when: network_config_os.json.data.content is search('ID=kali')
+      block:
+        - name: Checking that root is remounted read-write...
+          ansible.builtin.uri:
+            url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/exec"
+            headers:
+              Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
+            method: POST
+            body:
+              command:
+                - sh
+                - -c
+                - "if grep -q ID=kali /etc/os-release; then while mount | grep 'on / ' | grep -q ro,; do mount -o remount,rw / || true; sleep 1; done; fi"
+            body_format: json
+            validate_certs: "{{ proxmox_validate_certs }}"
+          register: network_config_command
+
+        - name: Including command run check task...
+          ansible.builtin.include_tasks: command_run_check.yml
+
     - name: Templating nmcli configuration files...
       ansible.builtin.template:
         src: "{{ item.src }}"
@@ -19,8 +52,7 @@
 
     - name: Removing any existing netplan configurations...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/exec"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/exec"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST
@@ -46,8 +78,7 @@
 
     - name: Writing following nmcli configuration files to {{ custom_vm_name | default(vm_name) }}...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/file-write"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/file-write"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST
@@ -64,8 +95,7 @@
 
     - name: Configuring network...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/exec"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/exec"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST

nova/core/roles/configure_networking/tasks/proxmox/opnsense.yml

@@ -1,12 +1,11 @@
 ---
-- name: Configuring netplan on Proxmox VM...
+- name: Configuring OPNsense on Proxmox VM...
   become: false
   delegate_to: localhost
   block:
     - name: Downloading /conf/config.xml {{ custom_vm_name | default(vm_name) }}...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/file-read?file=/conf/config.xml"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/file-read?file=/conf/config.xml"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: GET
@@ -114,8 +113,8 @@
     # Writing in 1700 char chunks because otherwise the Qemu Guest Agent service fails
     - name: Writing /conf/config.xml to {{ custom_vm_name | default(vm_name) }}...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/file-write"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node
+          }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/file-write"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST
@@ -136,8 +135,7 @@
 
     - name: Writing final /conf/config.xml to {{ custom_vm_name | default(vm_name) }}...
       ansible.builtin.uri:
-        url: "{{ proxmox_api_url }}/nodes/{{ proxmox_vm_info.proxmox_vms[0].node
-          }}/qemu/{{ proxmox_vm_info.proxmox_vms[0].vmid }}/agent/exec"
+        url: "{{ proxmox_api_url }}/nodes/{{ cfg_net_proxmox_node }}/qemu/{{ cfg_net_proxmox_vmid }}/agent/exec"
         headers:
           Authorization: PVEAPIToken={{ proxmox_defaults.api_user }}!{{ proxmox_defaults.api_token_id }}={{ proxmox_defaults.api_token_secret }}
         method: POST