[#705] - Disabled extra password reveal eye icon in Microsoft Edge#717
Open
jon-dalton wants to merge 2 commits intoCivicTechFredericton:developfrom
Open
[#705] - Disabled extra password reveal eye icon in Microsoft Edge#717jon-dalton wants to merge 2 commits intoCivicTechFredericton:developfrom
jon-dalton wants to merge 2 commits intoCivicTechFredericton:developfrom
Conversation
- Disabled the MS Edge password reveal icon so it doesn't appear in addition to the Material UI icon. - Changes also includes with CivicTechFredericton#672 branch as they have not been merged at time of commit
shanthisa
requested changes
Aug 15, 2024
Collaborator
shanthisa
left a comment
shanthisa
left a comment
There was a problem hiding this comment.
Duplicate meal name is part of this ticket which is not part of reveal eye icon. Please review your commits and files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the technical changes contained in this PR
Microsoft password reveal icon is disabled in HTML styles for the Login page. This does not disable the icon entirely, the Material UI icon still appears, it simply disables the Microsoft exclusive icon.
Previous behaviour
Two password reveal icons would appear in Microsoft Edge on the Login page. Login on other browsers is unaffected.
New behaviour
Only one password reveal icon appears in Microsoft Edge on the Login page. Login on other browsers is the same as before.
Steps to Replicate
Same as the initial issue.
Related issues addressed by this PR
Fixes #705
Have the following been addressed?