-
Notifications
You must be signed in to change notification settings - Fork 12
Vehicle management #33
base: master
Are you sure you want to change the base?
Conversation
| import com.programmerdan.minecraft.simpleadminhacks.configs.BetterVehiclesConfig; | ||
| import com.programmerdan.minecraft.simpleadminhacks.framework.SimpleHack; | ||
| import net.kyori.adventure.text.Component; | ||
| import org.bukkit.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- imports bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Imports bad" as in star import bad or as in all imports bad? You gotta be more specific than "bad" please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Star imports, github is assuming its a list point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* I think if you put a backslash in front it doesn't make it a list.
| import java.lang.reflect.Type; | ||
| import java.nio.file.Files; | ||
| import java.nio.file.Paths; | ||
| import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above
| ToggleLamp: | ||
| enabled: false | ||
| cooldownTime: 100 | ||
| BetterVehicles: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put this in alphabetical order
|
For some reason when exiting a minecart, you now sink into the floor? |
Can confirm, you don't sink into the floor when exiting a boat, but you do when exiting a minecart. @Diet-Cola and @psygate is it possible to integrate this vehicle management with a permission in /config, so that players can choose to enable or disable it? Is the logic behind this feature reducing how many stray vehicle are left out? And if so, would allowing players to opt-out of this feature defeat the purpose of it? Either way this is very cool, thank you psy |
It's a tick issue. I think I'll have to delay the entity removal by exactly one tick. I'll check. |
Yeah I think /config support would completely break its intended uses |
It wouldnt. Garbage collection would still run even without dismount drops. So either works. |
Boat and minecart management added.