Skip to content
This repository was archived by the owner on Feb 17, 2024. It is now read-only.

Conversation

@psygate
Copy link

@psygate psygate commented Jul 8, 2022

Boat and minecart management added.

import com.programmerdan.minecraft.simpleadminhacks.configs.BetterVehiclesConfig;
import com.programmerdan.minecraft.simpleadminhacks.framework.SimpleHack;
import net.kyori.adventure.text.Component;
import org.bukkit.*;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • imports bad

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Imports bad" as in star import bad or as in all imports bad? You gotta be more specific than "bad" please.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star imports, github is assuming its a list point

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* I think if you put a backslash in front it doesn't make it a list.

import java.lang.reflect.Type;
import java.nio.file.Files;
import java.nio.file.Paths;
import java.util.*;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

ToggleLamp:
enabled: false
cooldownTime: 100
BetterVehicles:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this in alphabetical order

@Diet-Cola
Copy link

For some reason when exiting a minecart, you now sink into the floor?

@Diet-Cola
Copy link

@wingzero54
Copy link

For some reason when exiting a minecart, you now sink into the floor?

Can confirm, you don't sink into the floor when exiting a boat, but you do when exiting a minecart.

@Diet-Cola and @psygate is it possible to integrate this vehicle management with a permission in /config, so that players can choose to enable or disable it? Is the logic behind this feature reducing how many stray vehicle are left out? And if so, would allowing players to opt-out of this feature defeat the purpose of it?

Either way this is very cool, thank you psy

@psygate
Copy link
Author

psygate commented Aug 13, 2022

For some reason when exiting a minecart, you now sink into the floor?

It's a tick issue. I think I'll have to delay the entity removal by exactly one tick. I'll check.

@Diet-Cola
Copy link

For some reason when exiting a minecart, you now sink into the floor?

Can confirm, you don't sink into the floor when exiting a boat, but you do when exiting a minecart.

@Diet-Cola and @psygate is it possible to integrate this vehicle management with a permission in /config, so that players can choose to enable or disable it? Is the logic behind this feature reducing how many stray vehicle are left out? And if so, would allowing players to opt-out of this feature defeat the purpose of it?

Either way this is very cool, thank you psy

Yeah I think /config support would completely break its intended uses

@psygate
Copy link
Author

psygate commented Aug 14, 2022

For some reason when exiting a minecart, you now sink into the floor?

Can confirm, you don't sink into the floor when exiting a boat, but you do when exiting a minecart.

@Diet-Cola and @psygate is it possible to integrate this vehicle management with a permission in /config, so that players can choose to enable or disable it? Is the logic behind this feature reducing how many stray vehicle are left out? And if so, would allowing players to opt-out of this feature defeat the purpose of it?

Either way this is very cool, thank you psy

Yeah I think /config support would completely break its intended uses

It wouldnt. Garbage collection would still run even without dismount drops. So either works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

No open projects
Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

5 participants