This repository was archived by the owner on Feb 18, 2024. It is now read-only.
Add NMS feature growers #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diet-Cola
approved these changes
Oct 4, 2022
Diet-Cola
left a comment
Diet-Cola
left a comment
There was a problem hiding this comment.
Solid PR, only left some minor notes but not enough to be blocking worthy
Will get on test
| featureSmall = RBFeatures.SHORT_SPRUCE.value(); | ||
| break; | ||
| case OAK_SAPLING: | ||
| feature = this.hasFlowers(world, pos) ? TreeFeatures.OAK_BEES_005.value() : TreeFeatures.OAK.value(); |
There was a problem hiding this comment.
small note but does NMS not contain a method to do this for us?
There was a problem hiding this comment.
Specifically checking nearby for flowers
Author
There was a problem hiding this comment.
it does but it's private so I copied it over
| BlockPos blockposition1; | ||
|
|
||
| do { | ||
| if (!iterator.hasNext()) { |
There was a problem hiding this comment.
Would this iterator loop be better as a
while(iter.hasNext()) {
//logic etc
}
Author
|
fixed flowering azalea not growing rosacarmesin@1c7c136 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds NMSFeatureGrower, which grows based on configuredFeatures through NMS, with name nmstree in config
when generating trees should it fail once it'll attempt to grow them a second time with the randomHeight attributes in the trunk generator set to 0