Skip to content

Conversation

@AngrySoundTech
Copy link
Contributor

@AngrySoundTech AngrySoundTech commented Feb 24, 2024

PR Comments will not work until they're on main, they should be good though since I copied them from our old projects

@AngrySoundTech AngrySoundTech requested review from okx-code and removed request for okx-code February 24, 2024 16:47
@okx-code
Copy link
Contributor

Can you explain what this does

@AngrySoundTech
Copy link
Contributor Author

Can you explain what this does

This PR Enables checks automatically to run on all PRs, which will run gradle check, and yamllint (errors currently ignored until we fix them all).

You can see the checks ran on this PR as a requirement before merging, taking 1 minute to ensure that the project builds, tests pass, and yaml files are formatted correctly (which will be more important especially when plugin config gets moved here). If we add code style checks and such to gradle, that will also be part of the check task

It also adds a workflow that comments with an easy link to the built artifact on the pr for testing, the output of which can be seen here: CivMC/CivModCore#98 (comment). Once this is merged that will start working, since the workflow needs to be on main

@AngrySoundTech AngrySoundTech merged commit 3833ddb into main Feb 24, 2024
@AngrySoundTech AngrySoundTech deleted the feature/pr-checks branch February 24, 2024 17:16
okx-code pushed a commit that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants