Update exceptions and cleanup code

[jseagrave21]

What current issue(s) does this address, or what feature is it adding?
See CityOfZion/neo-python#888

How did you solve this problem?

• per Update to throw exceptions instead of logging errors [np-core] neo-python#888:
  • removed logzero dependency
  • updated and clarified exception types raised
    • implemented LegendaireExponentError

How did you make sure your solution works?
make test

Did you add any tests?
only updated tests

edit
Added 1 test to increase Crypto.py coverage to 100%

Did you run make lint and make coverage?
Yes

Are there any special changes in the code that we should be aware of?
No

[ixje]

Overall good changes. There's a couple of inline comments I made and there's one more request I'd like to do here: Please update the docstrings to include the exceptions raised.

I know they're not always documented, and some might now have changed from Exception to ValueError or whatever. But we should really add them. See the style here: https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html

something along the lines of

Raises: 
   <exception type>: <description/cause>

[ixje]

Almost there. Just a couple of docstring suggestions/requests. The rest looks good :)

[ixje]

Before I can merge this we must update neo-python to support these changes. That way we can orchestrate a simultaneous new release of core + main

[jseagrave21]

Okay. I will start working on neo-python as well. Perhaps, I will be able to point make test to pull from my new branch like we did in CityOfZion/neo-python#716

[coveralls]

Coverage increased (+0.08%) to 96.614% when pulling 45974b0 on jseagrave21:update-exceptions into 786c02c on CityOfZion:master.

[jseagrave21]

I fixed the issues created by the updates in this branch CityOfZion/neo-python@master...jseagrave21:support-#888.

[jseagrave21]

After adding the above test, I am wondering if every user will understand that the message here

neo-python-core/neocore/Cryptography/Crypto.py

Line 110 in 090ae0a

message (str): message to be signed

should be a hexstr while the message here

neo-python-core/neocore/Cryptography/Crypto.py

Line 133 in 090ae0a

message (str): the message to verify.

could be a hexstr or a normal str.

[ixje]

From the 2 lines you've copied I cannot tell this, so that's already enough to indicate we need to clarify it.

To give you an idea what the docstrings look like in an IDE

Left upper balloon is the quick hints you get. If you don't understand the purpose from that you can request the extensive documentation that get formatted like the bottom right balloon.

[jseagrave21]

@ixje okay, I think it should be good

[jseagrave21]

Based on achieving a passing build and resolving all reviews/comments, I am reverting travis.yml to pull from the development branch. Please see CityOfZion/neo-python#911 for the neo-python PR.

[ixje]

see reasoning in comments

[ixje]

200 points jseagrave

[lllwvlvwlll]

https://neoscan.io/transaction/d5ae4a22ffe49912a2a3dc698d39ac63a8fcf2cef63ae136850d039c312591d8