Add base_address field to AIS output and precursor database tables#206
Open
mbjackson-capp wants to merge 3 commits intomasterfrom
Open
Add base_address field to AIS output and precursor database tables#206mbjackson-capp wants to merge 3 commits intomasterfrom
mbjackson-capp wants to merge 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "base_address" field to AIS address queries, which returns the
base_addressproperty from passyunk response components. This changes base_address from a "property" to an actual Column in several sqlalchemy models, and creates the relevant database field in the address_summary table (as well as precursor tables used to create it).After this PR is merged, we should do an official Alembic/SQLAlchemy migration to ensure that the tables in prod database exactly match the updated fields in
models.py. (I've been usingALTER TABLEstatements toADD COLUMNwhere needed in the ais-build-dev-matt database while testing.) We'll also want to add tests of base_address to the test suite