Replace "{}".format(x) strings with f"{x}" strings throughout library + other hygiene changes#205
Open
mbjackson-capp wants to merge 12 commits intomasterfrom
Open
Replace "{}".format(x) strings with f"{x}" strings throughout library + other hygiene changes#205mbjackson-capp wants to merge 12 commits intomasterfrom
mbjackson-capp wants to merge 12 commits intomasterfrom
Conversation
Contributor
Author
|
I am making more changes here and testing them, so will hold off on merging until this represents a larger merge of a larger set of the hygiene commits |
mbjackson-capp
changed the title
gis_planning.Neighborhoods gis_planning.Zoning_SteepSlopeProtectArea_r gis_planning.FEMA_100_FLOOD_PLAIN gis_planning.FEMA_500_FLOOD_PLAIN gis_planning.Land_Use gis_police.Boundaries_Sector gis_rda.lama_assets_0725 gis_orphan.Recreation_Districts gis_gsg.LITTER_SCHEMA_TEST
…now handled by reading attributes from passyunk_automation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step in the "code hygiene" project. Improves readability (and in some cases allows for trimming excess variable declarations).
I ran a build and ran a complete diff check against prod to make sure no errors were introduced, and almost everything is exactly the same; a couple hundred addresses differ with respect to unit type ("#" vs. "APT", e.g.) or attributes like zip or zip4. I am reasonably sure this is because the dev branch was a few passyunk(_automation) versions behind prod (2.26 instead of 2.31); I updated it and will run again over the weekend, so we can ensure there is an exact match before we merge. See ais_diff_fstring_06-27-25.txt.
If/when this is merged, we should not delete the branch; I plan to do additional "code hygiene" commits here and merge them as they are ready.