Ft conductor 16 dec2022 #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix for NPE when header values are null * fixed formatting Co-authored-by: mhubli <Muralidhar.Hubli@wolterskluwer.com>
* update doc for loop task * better language
* Added support for password authentication in RedisStandaloneConfiguration, RedisClusterConfiguration and RedisSentinelConfiguration * - Added a Redis Setup documentation page to the docs - Added a comment in application.properties
* Add visual Loop representation. * Check for predecessors before accessing parent.
only allow rerun on terminal workflows
* fix update with large payload task result * retryOperation method refactored Co-authored-by: Aravindan Ramkumar <1028385+aravindanr@users.noreply.github.com>
… clean up resolutions.
… created in the DoWhile.execute method. The DO_WHILE TaskModel is persisted before the loop-over tasks are created. Therefore, the loop-over tasks will have access the iteration field in DO_WHILE TaskModel.
…yloads. Previous implementation used one file, where payloads of different tasks can be overwritten.
Upgrade to Spring Boot 2.6.6
* Mark JOIN task which depends on an optional task that has COMPLETED_WITH_ERRORS with the same status (i.e. COMPLETED_WITH_ERRORS) * If subworkflow task is defined as optional in the parent workflow, the parent workflow status will not update even if the subworkflow is retried/rerun/restarted
Co-authored-by: Doug Sillars <doug.sillars@gmail.com>
Also remove duplicated content in README.
Bumps [spring-boot-gradle-plugin](https://github.com/spring-projects/spring-boot) from 2.3.12.RELEASE to 2.6.7. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.3.12.RELEASE...v2.6.7) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-gradle-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
* Fixed syntax highliting in starting-workflows.md * Fixed links in debugging-workflows.md Co-authored-by: Lukas Rampa <lukas.rampa@aimtecglobal.com>
Co-authored-by: skumar103 <sumit_kumar1@intuit.com>
Nginx was not running so the UI was not being served.
…ts from ES directly (Netflix#3283)
* add jitter to workflowoffset time * Add comment about jitter ranges * Instrument unack method Co-authored-by: Surafel Korse <skorse@netflix.com>
* batch polling in client * Deprecate shared threadpool and evenly split it between workers if that is supplied
…3320) * Allow overriding the thread count for the annotated workers * Added AnnotatedWorkerTests to cover how invocation parameters are created from annotations or inferred from their type and the input data * Refactoring + fix NPE when input parameter type is List and its value is null Co-authored-by: Miguel Prieto <miguelprieto@orkes.io>
* Simplifying the logic to check relevant task for do_while task The cases where decision/ fork_join, dynamic_fork is part of loop over task then ideally do_while task must wait before all the task gets completed. * integration tests * spotless * proper fix * spotless * integration test for remaining scenario. * removed not necessary test case. The test case was when decision task is part of loop over task and decision task contains two tasks and only one task is scheduled. But there will not be any case where we schedule only one task given the decision case has two tasks. * spotless * spotless 2 * spotless 3
charybr
approved these changes
Dec 19, 2022
charybr
reviewed
Dec 20, 2022
| } | ||
|
|
||
| public SearchResult<WorkflowSummary> searchWorkflowSummary( | ||
| String query, String freeText, int start, int count, List<String> sort) { |
There was a problem hiding this comment.
These are new changes, which doesnt conflict with existing ones.
charybr
reviewed
Dec 20, 2022
|
|
||
| public SearchResult<WorkflowSummary> search( | ||
| String query, String freeText, int start, int size, List<String> sortOptions) { | ||
|
|
There was a problem hiding this comment.
Since we have customized search() method (as part of ISICO-13954) to remove WF from indexDB when WF is not found in transactionalDB(Redis). We need to retain our changes.
|
as search returns WorkflowSummary instead of the Workflow object, you need to ensure elastic search as backup datastore is working fine. change the notification_url port to 7980 instead of 7979, and make bullwinkle notification fail so that workflow/tasks are indexed and they need to be processed by fusion correctly. please verify all cisco changes in this branch before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) Pulling latest changes from upstream repo Netflix main on 16 Dec 2022
b) Review is required in below file for the method 'search' since change has happened in upstream repo (Netflix@145ab53)