Add fabric_resource_policies_physical_interface resource and datasource (DCNE-386)#455
Open
sajagana wants to merge 5 commits intoCiscoDevNet:masterfrom
Open
Add fabric_resource_policies_physical_interface resource and datasource (DCNE-386)#455sajagana wants to merge 5 commits intoCiscoDevNet:masterfrom
sajagana wants to merge 5 commits intoCiscoDevNet:masterfrom
Conversation
sajagana
changed the title
sajagana
force-pushed
the
352_physical_interface
branch
from
3803724 to
38fb543
Compare
sajagana
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
samiib and
shrsr
as code owners
akinross
requested changes
Mar 23, 2026
mso/resource_mso_fabric_resource_policies_physical_interface.go
Outdated
Show resolved
Hide resolved
website/docs/r/fabric_resource_policies_physical_interface.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/fabric_resource_policies_physical_interface.html.markdown
Outdated
Show resolved
Hide resolved
sajagana
force-pushed
the
352_physical_interface
branch
3 times, most recently
from
75a02c0 to
29d5852
Compare
akinross
reviewed
Mar 26, 2026
mso/resource_mso_fabric_resource_policies_physical_interface.go
Outdated
Show resolved
Hide resolved
samiib
requested changes
Mar 29, 2026
website/docs/r/fabric_resource_policies_physical_interface.html.markdown
Outdated
Show resolved
Hide resolved
mso/datasource_mso_fabric_resource_policies_physical_interface.go
Outdated
Show resolved
Hide resolved
| payload["policyGroupType"] = "physical" | ||
| } else { | ||
| payload["breakoutMode"] = breakoutMode | ||
| payload["policyGroupType"] = "breakout" |
Collaborator
There was a problem hiding this comment.
Should policyGroupType get updated when breakout mode or policy UUID changes? Is that possible to update?
Collaborator
Author
There was a problem hiding this comment.
The policyGroupType is not auto-calculated for the breakout mode but it work for the physical interface policy group. Changed the logic only for physical interface policy group.
…ce and datasource
… and documentation
… test for the API config issues
…roup_uuid in the mso_fabric_resource_policies_physical_interface resource
…ist resource test file
sajagana
force-pushed
the
352_physical_interface
branch
from
2d7b2cc to
097d5f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.