Addition of resource and data source for tenant_policies_igmp_interface_policy (DCNE-278) by shrsr · Pull Request #403 · CiscoDevNet/terraform-provider-mso

shrsr · 2025-11-27T18:11:01Z

No description provided.

mso/utils.go

mso/resource_mso_tenant_policies_igmp_interface_policy.go

examples/tenant_policies_igmp_interface_policy/main.tf

samiib

LGTM

akinross

LGTM

gmicol

LGTM

mso/resource_mso_tenant_policies_igmp_interface_policy.go

akinross

LGTM

samiib

LGTM

gmicol

LGTM

lhercot

LGTM

lhercot

See issue in Go Release check: https://github.com/CiscoDevNet/terraform-provider-mso/actions/runs/20343107477/job/60651101226

Seems we need to reduce the test value to be under a int32

samiib

LGTM

akinross

LGTM

sajagana

LGTM!

mso/resource_mso_tenant_policies_igmp_interface_policy.go

…es_igmp_interface_policy

…s_igmp_interface_policy

…ons used in resource_mso_tenant_policies_igmp_interface_policy

…ies_igmp_interface_policy

…enant_policies_igmp_interface_policy

…_interface_policy

…nterface_policy to make type assertion checks

…se validateUint32Range()

mso/resource_mso_tenant_policies_igmp_interface_policy.go

…configuration by making computed false

akinross · 2026-03-30T07:45:10Z

mso/utils.go

+// is within the specified uint32 range. This approach avoids compile-time overflow
+// errors on 32-bit systems by storing boundaries as uint32 and performing runtime
+// validation using int64 comparisons.
+func validateUint32Range(min, max uint32) schema.SchemaValidateFunc {


@samiib has been introducing unit tests for new utils functions: https://github.com/CiscoDevNet/terraform-provider-mso/pull/456/changes#diff-f249e5942123363ce064241ccd77d4f98e910fe99db637fdc4a365a7ce62e853R8. Shall we do the same for this?

This function was more of a workaround for one case only to make the CI pass. I don't think this would require a unit test? I added a unit test for the other function in the route map PR.

Can you add that to the function explanation in that case?

akinross

LGTM

samiib

LGTM

sajagana

LGTM!

shrsr self-assigned this Nov 27, 2025

shrsr requested review from akinross, anvitha-jain, gmicol, lhercot, sajagana and samiib as code owners November 27, 2025 18:11

shrsr linked an issue Nov 27, 2025 that may be closed by this pull request

Create a resource and data source for "IGMP Interface Policy" object under Tenant Policies (DCNE-278) #325

Open

github-actions bot changed the title ~~Addition of resource and data source for tenant_policies_igmp_interface_policy~~ Addition of resource and data source for tenant_policies_igmp_interface_policy (DCNE-278) Nov 27, 2025

akinross requested changes Nov 28, 2025

View reviewed changes

mso/utils.go Outdated Show resolved Hide resolved

mso/resource_mso_tenant_policies_igmp_interface_policy.go Show resolved Hide resolved

mso/resource_mso_tenant_policies_igmp_interface_policy.go Outdated Show resolved Hide resolved

shrsr requested a review from akinross December 3, 2025 17:57

akinross requested changes Dec 4, 2025

View reviewed changes

examples/tenant_policies_igmp_interface_policy/main.tf Outdated Show resolved Hide resolved

examples/tenant_policies_igmp_interface_policy/main.tf Outdated Show resolved Hide resolved

shrsr requested a review from akinross December 4, 2025 16:39

samiib previously approved these changes Dec 5, 2025

View reviewed changes

akinross previously approved these changes Dec 10, 2025

View reviewed changes

gmicol previously approved these changes Dec 10, 2025

View reviewed changes

shrsr dismissed stale reviews from gmicol, akinross, and samiib via 0d2496a December 15, 2025 18:47

shrsr force-pushed the igmp branch from cf54b07 to 0d2496a Compare December 15, 2025 18:47

shrsr requested review from akinross, gmicol and samiib December 16, 2025 03:29

akinross requested changes Dec 18, 2025

View reviewed changes

mso/resource_mso_tenant_policies_igmp_interface_policy.go Show resolved Hide resolved

mso/resource_mso_tenant_policies_igmp_interface_policy.go Outdated Show resolved Hide resolved

mso/resource_mso_tenant_policies_igmp_interface_policy.go Outdated Show resolved Hide resolved

shrsr requested a review from akinross December 18, 2025 16:05

akinross previously approved these changes Dec 18, 2025

View reviewed changes

samiib previously approved these changes Jan 6, 2026

View reviewed changes

gmicol previously approved these changes Jan 6, 2026

View reviewed changes

lhercot approved these changes Jan 17, 2026

View reviewed changes

lhercot requested changes Jan 17, 2026

View reviewed changes

samiib previously approved these changes Mar 10, 2026

View reviewed changes

akinross previously approved these changes Mar 10, 2026

View reviewed changes

sajagana previously approved these changes Mar 10, 2026

View reviewed changes

shrsr dismissed stale reviews from sajagana, akinross, and samiib via 8f738b1 March 12, 2026 14:38

shrsr force-pushed the igmp branch from f3be32d to 8f738b1 Compare March 12, 2026 14:38

shrsr requested review from akinross, sajagana and samiib March 12, 2026 14:39

akinross requested changes Mar 13, 2026

View reviewed changes

mso/resource_mso_tenant_policies_igmp_interface_policy.go Show resolved Hide resolved

shrsr added 8 commits March 29, 2026 11:23

[minor_change] Addition of resource and data source for tenant_polici…

9227b0d

…es_igmp_interface_policy

[ignore] Removed debug log statement from resource_mso_tenant_policie…

e4a6c73

…s_igmp_interface_policy

[ignore] Modified addPatchPayloadToContainer to handle remove operati…

afac338

…ons used in resource_mso_tenant_policies_igmp_interface_policy

[ignore] Removed redundant code for remove operations in tenant_polic…

ecc91e3

…ies_igmp_interface_policy

[ignore] Reverted code to invoke remove op on certain conditions in t…

4974b5f

…enant_policies_igmp_interface_policy

[ignore] Removal of default values from docs for tenant_policies_igmp…

86040dc

…_interface_policy

[ignore] Modified setting data in resource_mso_tenant_policies_igmp_i…

e6ea9f6

…nterface_policy to make type assertion checks

[ignore] Made resource_mso_tenant_policies_igmp_interface_policy to u…

f6a66bf

…se validateUint32Range()

shrsr force-pushed the igmp branch from 8f738b1 to f6a66bf Compare March 29, 2026 15:24

shrsr requested a review from akinross March 29, 2026 15:24

samiib reviewed Mar 30, 2026

View reviewed changes

mso/resource_mso_tenant_policies_igmp_interface_policy.go Outdated Show resolved Hide resolved

[ignore] Added ability to delete a value for description from the TF …

3480a49

…configuration by making computed false

shrsr requested a review from samiib March 30, 2026 01:32

akinross requested changes Mar 30, 2026

View reviewed changes

shrsr requested a review from akinross March 31, 2026 00:23

[ignore] Added comments to utils for validateUint32Range

cfacd03

akinross approved these changes Apr 1, 2026

View reviewed changes

samiib approved these changes Apr 2, 2026

View reviewed changes

sajagana approved these changes Apr 7, 2026

View reviewed changes

Conversation

shrsr commented Nov 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samiib left a comment

Choose a reason for hiding this comment

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

gmicol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

samiib left a comment

Choose a reason for hiding this comment

Uh oh!

gmicol left a comment

Choose a reason for hiding this comment

Uh oh!

lhercot left a comment

Choose a reason for hiding this comment

Uh oh!

lhercot left a comment

Choose a reason for hiding this comment

Uh oh!

samiib left a comment

Choose a reason for hiding this comment

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

sajagana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

akinross Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

shrsr Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

akinross Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

samiib left a comment

Choose a reason for hiding this comment

Uh oh!

sajagana left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants