Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Resolves #254
Resolves #255
Proposed Changes
Add new
nd_manage_fabric_ai_ibgp_vxlanandnd_manage_fabric_ai_ebgp_vxlanmodules for managing AI/ML iBGP and eBGP VXLAN fabrics on Nexus Dashboard.New files:
plugins/module_utils/models/manage_fabric/manage_fabric_ai_ibgp_vxlan.py— Pydantic model withAimlVxlanIbgpManagementModelinheriting fromVxlanIbgpManagementModel(overrides type discriminator toaimlVxlanIbgp), andFabricAiIbgpVxlanModelwith shared fabric properties,Literal[FabricTypeEnum.AIML_VXLAN_IBGP]type discriminator, and single identifier strategy onfabric_nameplugins/module_utils/models/manage_fabric/manage_fabric_ai_ebgp_vxlan.py— Pydantic model withAimlVxlanEbgpManagementModelinheriting fromVxlanEbgpManagementModel(overrides type discriminator toaimlVxlanEbgp),FabricAiEbgpVxlanModelwithto_diff_dict()override excludingnxapiHttp, and single identifier strategy onfabric_nameplugins/module_utils/orchestrators/manage_fabric_ai_ibgp_vxlan.py— Orchestrator reusingEpManageFabrics*endpoints with customquery_allfiltering formanagement.type=="aimlVxlanIbgp"plugins/module_utils/orchestrators/manage_fabric_ai_ebgp_vxlan.py— Orchestrator reusingEpManageFabrics*endpoints with customquery_allfiltering formanagement.type=="aimlVxlanEbgp"plugins/modules/nd_manage_fabric_ai_ibgp_vxlan.py— Module supportingmerged,replaced,overridden, anddeletedstatesplugins/modules/nd_manage_fabric_ai_ebgp_vxlan.py— Module supportingmerged,replaced,overridden, anddeletedstatesModified files:
plugins/module_utils/models/manage_fabric/enums.py— AddedAIML_VXLAN_IBGP = "aimlVxlanIbgp"andAIML_VXLAN_EBGP = "aimlVxlanEbgp"toFabricTypeEnumNew tests:
tests/integration/targets/nd_manage_fabric/tasks/fabric_ai_ibgp.yaml— Integration tests covering create, update, replace, override, delete, check mode, and idempotencytests/integration/targets/nd_manage_fabric/tasks/fabric_ai_ebgp.yaml— Integration tests covering create, update, replace, override, delete, check mode, and idempotencytests/integration/targets/nd_manage_fabric/tasks/main.yaml— Added AI iBGP and AI eBGP test includestests/integration/targets/nd_manage_fabric/vars/main.yaml— Added AI iBGP and AI eBGP test variablesTest Notes
Cisco Nexus Dashboard Version
4.2.1
Related ND API Resource Category
Checklist