Skip to content

Conversation

@tiye
Copy link
Member

@tiye tiye commented Jan 7, 2026

No description provided.

@tiye tiye requested review from a team and Copilot January 7, 2026 08:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies single quote handling by removing escape sequences for single quotes in the Cirru writer and formatter, while maintaining backward compatibility in the parser. The version is bumped from 0.2.0 to 0.2.1.

  • Removes \' escape sequence generation in writer functions since single quotes are already allowed in identifiers
  • Maintains backward compatibility by keeping parser support for \' escape sequences
  • Adds comprehensive tests to verify single quote behavior with and without spaces

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/writer.rs Removes single quote escape handling in generate_leaf() function
src/primes.rs Removes single quote escape handling in escape_cirru_leaf() function
tests/writer_test.rs Adds two new tests verifying single quotes work unquoted without spaces and require quotes with spaces
tests/parser_test.rs Minor formatting improvements to condense multi-line assertions
examples/test_escape_debug.rs Consistent indentation formatting throughout the example file
Cargo.toml Version bump from 0.2.0 to 0.2.1
Cargo.lock Corresponding version update to 0.2.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants