Skip to content

Conversation

@tiye
Copy link
Member

@tiye tiye commented Sep 13, 2025

No description provided.

@tiye tiye requested a review from Copilot September 13, 2025 04:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a convenient conversion from boolean values to CirruWriterOptions by adding a From<bool> implementation. This allows users to pass a boolean directly to the format function instead of constructing CirruWriterOptions manually.

  • Added From<bool> implementation for CirruWriterOptions where true enables inline mode
  • Added comprehensive test coverage for the new boolean conversion functionality
  • Updated import ordering across multiple test files for consistency

Reviewed Changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/writer.rs Implements From<bool> trait for CirruWriterOptions
tests/writer_test.rs Adds test to verify boolean conversion works correctly with format function
tests/s_expr_test.rs Reorders imports alphabetically
tests/parser_test.rs Reorders imports alphabetically
tests/order_test.rs Reformats multi-line assertions to single lines
tests/lexer_test.rs Reorders imports alphabetically
examples/*.rs Reorders imports alphabetically in multiple example files
benches/*.rs Reorders imports alphabetically in benchmark files
Cargo.toml Version bump from 0.1.34 to 0.1.35

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@NoEgAm NoEgAm merged commit dc39335 into main Sep 16, 2025
1 check passed
@NoEgAm NoEgAm deleted the into-option branch September 16, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants