Skip to content

Conversation

@tiye
Copy link
Member

@tiye tiye commented Oct 16, 2025

No description provided.

@tiye tiye requested review from a team and Copilot October 16, 2025 17:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the Cirru writer API by replacing the CirruWriterOptions struct with a direct use_inline boolean parameter, and modernizes the codebase to use newer MoonBit syntax features.

  • Replaced CirruWriterOptions struct with direct use_inline parameter using optional syntax
  • Updated imports to use modern using syntax instead of typealias
  • Modernized various MoonBit syntax patterns throughout the codebase

Reviewed Changes

Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/writer.mbt Removed CirruWriterOptions struct and replaced with use_inline parameter
src/s_expr.mbt Fixed variable naming and updated string slicing syntax
src/parser_test.mbt Updated import syntax and function call to use new parameter format
src/moon.pkg.json Added test import configuration
src/main/moon.pkg.json Updated import format to use object syntax
src/main/main.mbt Updated import and function call syntax
src/lib/moon.pkg.json Removed empty configuration file
moon.mod.json Version bump to 0.2.0
README.md Updated documentation to reflect new syntax and API

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@NoEgAm NoEgAm merged commit 951e1eb into main Oct 21, 2025
2 checks passed
@NoEgAm NoEgAm deleted the update branch October 21, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants