Open
Conversation
…in debug_backtrace
TobiasHauck
reviewed
Mar 21, 2017
| $idColumns = !empty($meta) ? end($meta)->getIdentifierColumnNames() : []; | ||
|
|
||
| return !empty($idColumns) ? end($idColumns) : 'id'; | ||
| if (empty($idColumns)) { |
Member
There was a problem hiding this comment.
First of all: Thank you for contributing! And sorry for being that late.
In general your bugfix is a good one. But we just need to clean up the code a bit. If you had a look at the rest of the code we tried...
... not to mutate existing variables and
... not to create/mutate variables in a branch
Example:
if($x) {
$var = 'value';
} else {
$var = 'anotherValue';
}turns to
$var = $x ? 'value' : 'anotherValue';The idea is to use conditions as statements instead of expressions to ensure we don't generate side effects.
So what we need here is something like:
if(!empty($idColumns)) return end($idColumns);
$reservedTokens = array_filter($tokens['SELECT'], function($token) {
return $token['expr'] === 'reserved';
});
$finalTokens = count($reservedTokens) > 0 ? $reservedTokens : $tokens;
return end($finalTokens[0]['no_quotes']['parts']);Maybe I missed a detail, but I hope it helps you to understand what I want to change here.
May you be so kind and change these few lines so I can merge the PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContextErrorException: Notice: Undefined index: CURLOPT_HTTPHEADER
Fixes #45