Skip to content

Conversation

@Jung-eunwoo
Copy link
Contributor

@Jung-eunwoo Jung-eunwoo commented May 3, 2024

Issues 번호 :

Closes #63

변경, 추가된 코드(설명 등)

  • CpIconCircleButton내부에 tooltip을 추가.
    • 기본적으로는 비활성화되도록 설정.
  • tooltipContent 속성을 통해 tooltip의 내용을 지정할 수 있도록 설정.
  • 기본적인 위치는 top으로 고정
  • 전체적으로 밝은 앱의 분위기를 고려해 light 테마로 변경

코드 주의점

스크린샷

image

Summary by CodeRabbit

- New Feature: CpIconCircleButton 및 TreeDetailFooter 컴포넌트에 툴팁 추가
- New Feature: 툴팁은 기본적으로 비활성화되며 `tooltipContent` 속성을 통해 내용 지정 가능
- Style: CpIconCircleButton 및 TreeDetailFooter 컴포넌트의 테마 light로 변경

CpIconCircleButton내부에 elemental plus의 tooltip을 추가.
@Jung-eunwoo Jung-eunwoo self-assigned this May 3, 2024
@Jung-eunwoo Jung-eunwoo requested a review from doyou1 May 3, 2024 16:06
@github-actions
Copy link

github-actions bot commented May 3, 2024

Image description CodeRabbit

개요:

CpIconCircleButton 및 TreeDetailFooter 컴포넌트에 툴팁이 추가되었습니다. 기본적으로 비활성화되어 있고, tooltipContent 속성을 통해 내용을 지정할 수 있습니다. 또한 테마가 light로 변경되었습니다.

상세 정보:

파일 경로 변경 내용
src/components/commons/CpButton.stories copy.ts -
src/components/commons/CpIconCircleButton.vue 툴팁 추가, tooltipContent 속성으로 내용 지정 가능, 테마 light로 변경
src/components/tree/detail/TreeDetailFooter.vue 툴팁 추가, tooltipContent 속성으로 내용 지정 가능, 테마 light로 변경

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 2fd4909 and 79a9b29 commits.
Files selected (3)
  • src/components/commons/CpButton.stories copy.ts (1)
  • src/components/commons/CpIconCircleButton.vue (4)
  • src/components/tree/detail/TreeDetailFooter.vue (3)
Review comments generated (6)
  • Review: 1
  • LGTM: 5

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

import { defineProps, defineEmits, computed } from "vue";
import { ElButton } from "element-plus";
import { ElButton, ElTooltip} from "element-plus";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

retrn이 아닌 return으로 수정해야 합니다.

-    retrn z
+    return z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

트리보기 하단 버튼에 tooltip

2 participants