#64 design init 페이지 글자 굵기가 얇아짐 #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
font-weight로 제어
|
개요:전체적으로 "Pretendard-Regular" 폰트를 "Pretendard"로 대체하고 굵기를 700으로 설정했습니다. 상세 정보:
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (1)
- src/assets/typography.scss (1)
Files ignored due to filter (5)
- src/assets/fonts/Pretendard-Regular.eot
- src/assets/fonts/Pretendard-Regular.svg
- src/assets/fonts/Pretendard-Regular.ttf
- src/assets/fonts/Pretendard-Regular.woff
- src/assets/fonts/Pretendard-Regular.woff2
Review comments generated (2)
- Review: 1
- LGTM: 1
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
Comment on lines
1
to
9
| body * { | ||
| font-family: "Pretendard-Regular"; | ||
| --el-font-family:"Pretendard-Regular"; | ||
| @font-face { | ||
| font-family: "Pretendard-Regular"; | ||
| src: url("./fonts/Pretendard-Regular.ttf") format("truetype"); | ||
| src: url("./fonts/Pretendard-Regular.eot"); /* IE9 Compat Modes */ | ||
| src: url("./fonts/Pretendard-Regular.eot?#iefix") format("embedded-opentype"), /* IE6-IE8 */ | ||
| url("./fonts/Pretendard-Regular.woff2") format("woff2"), /* Super Modern Browsers */ | ||
| url("./fonts/Pretendard-Regular.woff") format("woff"), /* Pretty Modern Browsers */ | ||
| url("./fonts/Pretendard-Regular.svg#svgFontName") format("svg"); /* Legacy iOS */ | ||
| } | ||
| } | ||
| font-family: "Pretendard"; | ||
| font-style: normal; | ||
| font-weight: 700; | ||
| --el-font-family:"Pretendard"; | ||
| } | ||
|
|
||
| /** 새로 추가된 폰트(!important는 element-plus component에도 적용하기 위해서) */ | ||
| .cp-text-head-1 { |
There was a problem hiding this comment.
Note: This review was outside of the patch, but no patch was found that overlapped with it. Original lines [22-22]
폰트 굵기를 700으로 변경한 것은 올바른 조치입니다.
- font-family: "Pretendard";
+ font-family: "Pretendard-Regular";
Contributor
|
그 부분 외에는 완벽합니다!!! bbb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues 번호 :
Closes #64
변경, 추가된 코드(설명 등)
코드 주의점
스크린샷
Summary by CodeRabbit