Skip to content

Vulns should raise #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophe-havard-sonarsource wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Vulns should raise #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions sqlquery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?php

use Symfony\Component\HttpFoundation\Request;

class Controller
{
/**
* @var \Doctrine\DBAL\Connection
*/
protected $connection;

public function sqlQuery1(Request $request)
{
$userId = $request->get('id');
$sql = "SELECT email FROM user WHERE id='$userId'";
$statement = $this->connection->prepare($sql);

Check failure

Code scanning / SonarCloudsquad-1

Database queries should not be vulnerable to injection attacks

<!--SONAR_ISSUE_KEY:AYGqXI48KW4f87dK4H6f-->Change this code to not construct SQL queries directly from user-controlled data.
$statement->execute();
$username = $statement->fetchColumn();
return $this->json(['email' => $username]);
}
}
?>