UX-22: Today - reduce card density and add visual hierarchy#633
UX-22: Today - reduce card density and add visual hierarchy#633Chris0Jeky merged 3 commits intomainfrom
Conversation
- Zero-count collapse: stats with count=0 render as compact chip row - Visual hierarchy: ember accent border on urgent stats/sections - Progressive disclosure: first 3 agenda sections expanded, rest behind "Show more" - Spacing: increase gaps from space-3/4 to space-5/6 (~1.1-1.3rem) - Card differentiation: left-border color coding (ember for urgent, neutral for informational) - Muted styling for zero-count badges
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Adversarial Self-ReviewAcceptance Criteria Check
Potential Issues Found
VerdictNo blocking issues found. One minor improvement opportunity (empty stats section guard) that I will fix now. |
There was a problem hiding this comment.
Code Review
This pull request refactors the TodayView to improve information density and visual hierarchy. It introduces progressive disclosure for agenda sections via a 'Show more' button and categorizes statistics into active cards and compact chips for zero values. Additionally, it implements urgency-based styling for both stats and agenda cards. Feedback suggests extending the urgent highlighting to the 'triage' statistic to maintain consistency with the corresponding agenda section.
| v-for="stat in activeStats" | ||
| :key="stat.id" | ||
| class="td-panel td-today-stat" | ||
| :class="{ 'td-today-stat--urgent': stat.id === 'review' || stat.id === 'overdue' }" |
There was a problem hiding this comment.
For visual consistency with the agenda sections, the 'Needs triage' stat (ID: triage) should also be marked as urgent. Currently, only review and overdue are highlighted, but the corresponding 'Capture triage' agenda section is marked as ember (urgent). Using an array with .includes() also makes this logic more readable and easier to maintain.
:class="{ 'td-today-stat--urgent': ['review', 'overdue', 'triage'].includes(stat.id) }"
Align stat card urgency with the ember-colored Capture triage agenda section by including 'triage' in the urgent stat IDs.
Summary
space-3/space-4tospace-5/space-6(~1.1-1.3rem) for better breathing roomCloses #622
Test plan
npm run typecheckandnpm run build- both pass