UX-27: Soften Home primary action card color#629
Conversation
Replace full ember-red background on .td-home-action--primary with ember-dim (10% opacity) background and ember left-border accent. Reserve full-red backgrounds for actual urgency states. Closes #627
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Adversarial Self-ReviewDiff reviewed: 1 file changed, 5 insertions, 4 deletions. CSS-only change in HomeView.vue. Findings
VerdictNo bugs or issues found. Change is minimal, focused, and matches the issue spec exactly. |
There was a problem hiding this comment.
Code Review
This pull request updates the styling for primary home actions in HomeView.vue, including changes to background colors, text colors, and the addition of a left border. Feedback was provided regarding a hardcoded RGBA value in the hover state, suggesting the use of a design token with color-mix to ensure theme consistency.
| .td-home-action--primary:hover { | ||
| background: var(--td-color-ember); | ||
| box-shadow: 0 0 20px rgba(255, 83, 82, 0.25); | ||
| background: rgba(255, 77, 77, 0.18); |
There was a problem hiding this comment.
The hover background uses a hardcoded RGBA value (rgba(255, 77, 77, 0.18)). This bypasses the design token system and will not adapt correctly to the Light Theme, where the ember accent color is different (defined as #d93636 in design-tokens.css). Use color-mix with the --td-color-ember token to ensure theme consistency and maintainability.
background: color-mix(in srgb, var(--td-color-ember) 18%, transparent);
Replace hardcoded rgba(255, 77, 77, 0.18) with color-mix(in srgb, var(--td-color-ember) 18%, transparent) so hover adapts to theme.
Summary
--td-color-ember-glow) background on.td-home-action--primarywith subtle--td-color-ember-dim(10% opacity) backgroundborder-left: 3px solid var(--td-color-ember)accent for visual hierarchy without alarmCloses #627
Test plan