Skip to content

UX-27: Soften Home primary action card color#629

Merged
Chris0Jeky merged 2 commits intomainfrom
feature/627-home-action-color
Mar 31, 2026
Merged

UX-27: Soften Home primary action card color#629
Chris0Jeky merged 2 commits intomainfrom
feature/627-home-action-color

Conversation

@Chris0Jeky
Copy link
Copy Markdown
Owner

Summary

  • Replace full ember-red (--td-color-ember-glow) background on .td-home-action--primary with subtle --td-color-ember-dim (10% opacity) background
  • Add border-left: 3px solid var(--td-color-ember) accent for visual hierarchy without alarm
  • Soften hover state: lighter rgba overlay instead of full ember + red glow box-shadow
  • Reserve full-red backgrounds for actual urgency (overdue, blocked items)

Closes #627

Test plan

  • Visual check: Home view "Next Step" card should appear as a subtle ember-tinted card, not alarming red
  • Hover state should slightly darken the ember tint without a red glow
  • Light mode: verify ember-dim token renders correctly (uses different opacity)
  • No regressions on secondary action cards

Replace full ember-red background on .td-home-action--primary with
ember-dim (10% opacity) background and ember left-border accent.
Reserve full-red backgrounds for actual urgency states.

Closes #627
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky
Copy link
Copy Markdown
Owner Author

Adversarial Self-Review

Diff reviewed: 1 file changed, 5 insertions, 4 deletions. CSS-only change in HomeView.vue.

Findings

  1. Hardcoded hover rgba value (minor): The hover state uses rgba(255, 77, 77, 0.18) instead of a design token. There is no existing token at ~18% opacity in design-tokens.css — the closest is --td-color-ember-dim at 10%. This is acceptable for now but could be extracted to a token if the pattern recurs.

  2. border-left vs base border shorthand: The base .td-home-action sets border: 0.5px solid transparent on all sides. The primary modifier overrides only border-left: 3px solid. This works correctly — CSS specificity means the left border gets the 3px ember, other sides keep 0.5px transparent. The 3px left border adds ~2.5px extra width which is negligible in a flex layout. No layout shift concern.

  3. Light mode token behavior: --td-color-ember-dim has a separate light-mode definition using rgb(var(--_td-light-accent-rgb) / 0.07) — this will render even subtler in light mode, which is the correct direction.

  4. Transition coverage: The base class transitions background, border-color, and box-shadow — the border-left change is static (not on hover), so the transition still covers the hover background change. The box-shadow: none on hover will transition smoothly from the base transparent border.

  5. Acceptance criteria check:

    • Background changed from full ember to ember-dim
    • Color changed from inverse to primary text
    • border-left accent added
    • Hover state softened (no red glow)
    • Full-red reserved for urgency only

Verdict

No bugs or issues found. Change is minimal, focused, and matches the issue spec exactly.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the styling for primary home actions in HomeView.vue, including changes to background colors, text colors, and the addition of a left border. Feedback was provided regarding a hardcoded RGBA value in the hover state, suggesting the use of a design token with color-mix to ensure theme consistency.

.td-home-action--primary:hover {
background: var(--td-color-ember);
box-shadow: 0 0 20px rgba(255, 83, 82, 0.25);
background: rgba(255, 77, 77, 0.18);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The hover background uses a hardcoded RGBA value (rgba(255, 77, 77, 0.18)). This bypasses the design token system and will not adapt correctly to the Light Theme, where the ember accent color is different (defined as #d93636 in design-tokens.css). Use color-mix with the --td-color-ember token to ensure theme consistency and maintainability.

  background: color-mix(in srgb, var(--td-color-ember) 18%, transparent);

Replace hardcoded rgba(255, 77, 77, 0.18) with color-mix(in srgb,
var(--td-color-ember) 18%, transparent) so hover adapts to theme.
@Chris0Jeky Chris0Jeky merged commit ef9f647 into main Mar 31, 2026
22 checks passed
@Chris0Jeky Chris0Jeky deleted the feature/627-home-action-color branch March 31, 2026 14:49
@github-project-automation github-project-automation bot moved this from Pending to Done in Taskdeck Execution Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

UX-27: Home — soften Next Step primary action card color

1 participant