-
Notifications
You must be signed in to change notification settings - Fork 0
fix: scope LLM queue list to authenticated user (#508) #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7fc43e2
Add GetByUserAndStatusAsync to ILlmQueueRepository for user-scoped st…
Chris0Jeky 39667c5
Implement GetByUserAndStatusAsync in LlmQueueRepository with UserId p…
Chris0Jeky fb70e04
Scope GetQueueByStatusAsync and GetQueueStatsAsync to userId in ILlmQ…
Chris0Jeky a112890
Filter GetQueueByStatusAsync and GetQueueStatsAsync by userId in LlmQ…
Chris0Jeky ae7f792
Extract userId from claims in GetByStatus and GetQueueStats to preven…
Chris0Jeky b92c664
Update LlmQueueServiceTests to use new GetByUserAndStatusAsync mock s…
Chris0Jeky 7d295a9
Add cross-user isolation tests for GetByStatus and GetQueueStats endp…
Chris0Jeky 664290c
Add GetStatusCountsByUserAsync to ILlmQueueRepository
Chris0Jeky fbcd9a7
Implement GetStatusCountsByUserAsync and add AsNoTracking to LlmQueue…
Chris0Jeky 8867e9a
Replace 4 DB calls in GetQueueStatsAsync with single GROUP BY query
Chris0Jeky 11e1779
Update LlmQueueServiceTests to mock GetStatusCountsByUserAsync
Chris0Jeky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this method is used for read-only operations where the entities are mapped to DTOs, it would be more efficient to disable change tracking by adding
.AsNoTracking()to the query. This avoids the overhead of setting up change tracking for entities that won't be updated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed: added
.AsNoTracking()to both SQLite and LINQ branches ofGetByUserAndStatusAsync. Also added.Include(lr => lr.User)for consistency withGetByStatusAsync.