Skip to content

fix: render markdown in chat assistant messages (#518) #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris0Jeky merged 2 commits into from
Mar 29, 2026
Merged

fix: render markdown in chat assistant messages (#518) #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4083ca8
fix: render markdown in chat assistant messages (#518)
Chris0Jeky Mar 29, 2026
e01cc9c
fix: harden markdown rendering security — fail-closed role fallback a…
Chris0Jeky Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions frontend/taskdeck-web/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions frontend/taskdeck-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,16 @@
"@microsoft/signalr": "^10.0.0",
"@tanstack/vue-virtual": "^3.13.23",
"axios": "^1.13.2",
"dompurify": "^3.3.3",
"marked": "^17.0.5",
"pinia": "^3.0.4",
"vue": "^3.5.24",
"vue-router": "^4.6.3",
"ws": "file:vendor/ws-7.5.10.tgz"
},
"devDependencies": {
"@playwright/test": "^1.56.1",
"@types/dompurify": "^3.0.5",
"@types/node": "^24.10.0",
"@typescript-eslint/eslint-plugin": "^8.46.2",
"@typescript-eslint/parser": "^8.46.2",
Expand Down
4 changes: 2 additions & 2 deletions frontend/taskdeck-web/src/utils/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ const chatSessionStatusByIndex = ['Active', 'Archived'] as const

export function normalizeChatRole(value: ChatRoleValue): typeof chatRoleByIndex[number] {
if (typeof value === 'number') {
return chatRoleByIndex[value] ?? 'Assistant'
return chatRoleByIndex[value] ?? 'User'
}

const found = chatRoleByIndex.find(v => v.toLowerCase() === value.toLowerCase())
return found ?? 'Assistant'
return found ?? 'User'
}

export function normalizeChatSessionStatus(value: ChatSessionStatusValue): typeof chatSessionStatusByIndex[number] {
Expand Down
111 changes: 109 additions & 2 deletions frontend/taskdeck-web/src/views/AutomationChatView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
<script setup lang="ts">
import { computed, onMounted, ref, watch } from 'vue'
import { useRoute, useRouter } from 'vue-router'
import { marked } from 'marked'
import DOMPurify from 'dompurify'
import { chatApi } from '../api/chatApi'
import { boardsApi } from '../api/boardsApi'
import { useToastStore } from '../store/toastStore'
import type { ChatProviderHealth, ChatSession } from '../types/chat'
import type { ChatProviderHealth, ChatMessage, ChatSession } from '../types/chat'
import type { Board } from '../types/board'
import { normalizeChatRole } from '../utils/chat'
import { getErrorDisplay } from '../composables/useErrorMapper'
Expand All @@ -13,6 +15,18 @@ import { buildInputAssistOptions } from '../utils/inputAssist'
import type { InputAssistOption } from '../utils/inputAssist'
import { normalizeBoardIdQueryParam } from '../utils/navigation'

function isAssistantOrSystemMessage(message: ChatMessage): boolean {
const role = normalizeChatRole(message.role)
return role === 'Assistant' || role === 'System'
}

function renderMarkdown(content: string): string {
if (!content) {
return ''
}
return DOMPurify.sanitize(marked.parse(content, { async: false }))
}
Comment on lines +23 to +28
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved robustness, it's a good practice to wrap the markdown parsing and sanitization logic in a try...catch block. This will prevent a single malformed message from the assistant from breaking the entire chat message display. If an error occurs, we can log it and display a safe, user-friendly error message.

function renderMarkdown(content: string): string {
  if (!content) {
    return ''
  }
  try {
    return DOMPurify.sanitize(marked.parse(content) as string)
  } catch (e) {
    console.error('Failed to render markdown content:', e)
    return '<p><em>Error rendering message content.</em></p>'
  }
}


const router = useRouter()
const route = useRoute()
const toast = useToastStore()
Expand Down Expand Up @@ -563,7 +577,12 @@ watch(
<div v-if="message.messageType === 'degraded'" class="td-message-degraded-warning">
Degraded response{{ message.degradedReason ? `: ${message.degradedReason}` : '' }}
</div>
<div class="td-message-content">{{ message.content }}</div>
<div
v-if="isAssistantOrSystemMessage(message)"
class="td-message-content td-message-content--markdown"
v-html="renderMarkdown(message.content)"
></div>
<div v-else class="td-message-content">{{ message.content }}</div>
<div v-if="message.proposalId && message.messageType === 'proposal-reference'" class="td-message-proposal">
<span>Proposal: {{ message.proposalId }}</span>
<button
Expand Down Expand Up @@ -827,6 +846,94 @@ watch(
font-size: var(--td-font-sm);
}

.td-message-content--markdown {
white-space: normal;
}

.td-message-content--markdown :deep(p) {
margin: 0 0 var(--td-space-2);
}

.td-message-content--markdown :deep(p:last-child) {
margin-bottom: 0;
}

.td-message-content--markdown :deep(h1),
.td-message-content--markdown :deep(h2),
.td-message-content--markdown :deep(h3),
.td-message-content--markdown :deep(h4),
.td-message-content--markdown :deep(h5),
.td-message-content--markdown :deep(h6) {
margin: var(--td-space-2) 0 var(--td-space-1);
font-weight: 700;
color: var(--td-text-primary);
}

.td-message-content--markdown :deep(h1) { font-size: var(--td-font-xl); }
.td-message-content--markdown :deep(h2) { font-size: var(--td-font-lg); }
.td-message-content--markdown :deep(h3) { font-size: var(--td-font-base); }

.td-message-content--markdown :deep(ul),
.td-message-content--markdown :deep(ol) {
margin: 0 0 var(--td-space-2);
padding-left: var(--td-space-4);
}

.td-message-content--markdown :deep(li) {
margin-bottom: var(--td-space-1);
}

.td-message-content--markdown :deep(code) {
font-family: monospace;
font-size: 0.9em;
background: var(--td-surface-tertiary);
border: 1px solid var(--td-border-default);
border-radius: var(--td-radius-sm);
padding: 1px 4px;
}

.td-message-content--markdown :deep(pre) {
background: var(--td-surface-tertiary);
border: 1px solid var(--td-border-default);
border-radius: var(--td-radius-md);
padding: var(--td-space-2) var(--td-space-3);
overflow-x: auto;
margin: 0 0 var(--td-space-2);
}

.td-message-content--markdown :deep(pre code) {
background: none;
border: none;
padding: 0;
font-size: var(--td-font-sm);
}

.td-message-content--markdown :deep(strong) {
font-weight: 700;
}

.td-message-content--markdown :deep(em) {
font-style: italic;
}

.td-message-content--markdown :deep(blockquote) {
border-left: 3px solid var(--td-border-default);
margin: 0 0 var(--td-space-2);
padding-left: var(--td-space-3);
color: var(--td-text-secondary);
}

.td-message-content--markdown :deep(hr) {
border: none;
border-top: 1px solid var(--td-border-default);
margin: var(--td-space-2) 0;
}

.td-message-content--markdown :deep(a) {
color: var(--td-color-primary);
text-decoration: underline;
}

.td-message--degraded {
border-left: 3px solid var(--td-color-warning, #d69e2e);
padding-left: var(--td-space-2);
Expand Down
Loading