Open
Conversation
Repurposed the function to work despite the server giving it the big "NO". And added an attribute to force music playing on the spot.
The function exists to change music upon entering an area with the auto_getmusic attribute or change_to_getmusic are True.
Okay, this is a big one. -> Added Three Music Related Commands: /getmusic, /autogetmusic, /setgetmusic -> Added One Summon Related Command: /summon_all -> Quality of Life Changes for /look - /getmusic: This command will play the current area's music. It will not play anything if there's no music playing. - /autogetmusic: A client toggle that, if True, will play the current area's music upon entering any area. It is False by default. - /setgetmusic: An area toggle that, if True, will play the current area's music upon entering the area. It is False by default and works per area. - /summon_all: Works similar to /summon, but will take EVERYONE BUT STAFF within the hub's areas and move them to the argument's area. - /look: Now writes Area ID before Area Name. Example: === Look results for Area <area_id>: <area_name> ===
|
What is this PR even supposed to do? What do each of these additions/commands even do? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are slight additions, but they mean well, especially the /getmusic command that everyone is looking forward to. It gives options for those who actually like the old feature of music changing per area before it was omitted.