Skip to content

PlayerCard Panel: Ensure "Other" always shows up in content list #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dscarpac merged 1 commit into from
Apr 3, 2026
Merged

PlayerCard Panel: Ensure "Other" always shows up in content list #1705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/playercards/AllCardsBag.ttslua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,8 +509,9 @@ end

-- Expects a table like { [1] = true, [2] = false, [0] = true }
function getFilteredContent(activeChapters)
local matches = {}
local seen = {}
local matches = {}
local seen = {}
local hasOther = false

local function processCycle(cycleName)
if seen[cycleName] then return end
Expand All @@ -519,6 +520,7 @@ function getFilteredContent(activeChapters)
if activeChapters[chapter] and cycleIndex[cycleName] and cycleHasSpawnableCards(cycleName) then
table.insert(matches, toTitleCase(cycleName))
seen[cycleName] = true
if cycleName == "other" then hasOther = true end
end
end

Expand All @@ -532,6 +534,10 @@ function getFilteredContent(activeChapters)
processCycle(cycleName)
end

if not hasOther then
table.insert(matches, "Other")
end

return matches
end

Expand Down
Loading