Add configurable abort timeout and retries for webhook-caller service #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mksh
force-pushed
the
configurable-webhook-timeout-retries
branch
from
698656b to
3494ed0
Compare
mksh
force-pushed
the
configurable-webhook-timeout-retries
branch
from
3494ed0 to
1eaa6cb
Compare
jenpaff
approved these changes
Apr 12, 2024
jenpaff
left a comment
jenpaff
left a comment
There was a problem hiding this comment.
LGTM! will we send a PR for upstream?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of the features present in https://github.com/lidofinance/lido-ts-nanolib/, and so does not need any new packages or explicit retries/abort logic.