Fix plugin settings to display default values when not configured in the DB#7484
Open
himi-sh wants to merge 2 commits intoChocobozzz:developfrom
Open
Fix plugin settings to display default values when not configured in the DB#7484himi-sh wants to merge 2 commits intoChocobozzz:developfrom
himi-sh wants to merge 2 commits intoChocobozzz:developfrom
Conversation
himi-sh
changed the title
himi-sh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue where settingsManager.getSetting() returns undefined when a setting has not yet been configured by an administrator, even if a default value is provided during registerSetting
Related issues
Fixed issue of #6660
Has this been tested?
Screenshots
These screenshots demonstrate the default value on the Plugin settings page