-
Notifications
You must be signed in to change notification settings - Fork 32
Implemented the bulk add feature requested in #223 #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks! I defer to @alkazar since I can't understand python |
|
That is some awesome work. My main concern is overloading the SteamGridDB API limits. We have already had our API token revoked once due to overuse and it is very disruptive. In order for this to be deployed we would have to create and run some kind of proxy server to SteamGridDB. |
|
Yea I worried there would be some kind of rate limiting.
Does chimera just have one token that is supplied with the install?
Or is this associated with the users steam account?
The reason I ask is that if we can store that api key when a user logs into steam on the device we can utilize their key to make the calls instead of a shared one.
I’m not sure what the rate limiting level is but I would be surprised if a person even with thousands of roms would be able to be able to hit that limit.
…On Fri, Sep 26, 2025 at 12:32 PM Alesh Slovak ***@***.***> wrote:
*alkazar* left a comment (ChimeraOS/chimera#326)
<#326 (comment)>
That is some awesome work. My main concern is overloading the SteamGridDB
API limits. We have already had our API token revoked once due to overuse
and it is very disruptive.
In order for this to be deployed we would have to create some kind of
proxy server to SteamGridDB.
—
Reply to this email directly, view it on GitHub
<#326 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZ3JQ33KP7DUXQSTSRWYN33UVTAVAVCNFSM6AAAAACHRRDOOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMZZGUYDSNZRHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
f93da5c to
570049e
Compare
|
I added a quick change to the change per our discussion @alkazar. I added in functionality that prevents the bulk upload functionality unless the user has added their own personal API key via the settings section. This should prevent the risk of rate limiting based on the current chimera api key. |
|
Thanks! I hope alkazar will find it amusing as I do. |
It’s my first ever attempt at contributing to open source. I hope I screw something up to warrant the humor. |
This is my first ever attempt at open source contribution, so apologies in advance if I am not following the proper process.
I did not write any automated tests however I did test by uploading around 20-40 games at a time for n64, ps1, and atari.
Workflow Changes
Backend