Skip to content

Re-designed the profile page -- GSSOC 2021#92

Open
varmor wants to merge 1 commit intoChetnaNSharma:mainfrom
varmor:main
Open

Re-designed the profile page -- GSSOC 2021#92
varmor wants to merge 1 commit intoChetnaNSharma:mainfrom
varmor:main

Conversation

@varmor
Copy link
Copy Markdown

@varmor varmor commented May 5, 2021

Issue solved

Closes: # 89


Changes Proposed

Redesigned the profile page to make it more attractive.

Brief description of what is fixed/changed

I have completely redesigned the profile page from scratch .


Types of changes made:

I have changed the previous "profile.html" from the profile folder, and also added styling in different file named "profile.css", previously styling was done in the html file but now i have seperated it and linked it with the html file.

  • [ x] Bugfix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist:

  • My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [ x] My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface
image
image


Other information

Any other information that is important to this pull request

@varmor
Copy link
Copy Markdown
Author

varmor commented May 5, 2021

@yash982000 can you review this code and let me know if i went wrong.

@yash982000
Copy link
Copy Markdown
Collaborator

@yash982000 can you review this code and let me know if i went wrong.

Can you please check the profile design?
It's different but it's fine if it is good.
You can consult with @ChetnaNSharma in this case.
She can guide you better.

@yash982000 yash982000 closed this May 11, 2021
@yash982000 yash982000 reopened this May 11, 2021
@varmor
Copy link
Copy Markdown
Author

varmor commented May 13, 2021

okay, so i need to make changes according to her (@ChetnaNSharma ) then you will merge my request .

@yash982000
Copy link
Copy Markdown
Collaborator

okay, so i need to make changes according to her (@ChetnaNSharma ) then you will merge my request .

Yes @Varunmore

Copy link
Copy Markdown
Collaborator

@yash982000 yash982000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

@yash982000 yash982000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants