Skip to content

升級至 .NET 8 並解決相容性問題 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChengBoChuan merged 1 commit into from
Oct 26, 2025
Merged

升級至 .NET 8 並解決相容性問題 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion InfiniteDemand/InfiniteDemand.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,17 @@
</PropertyGroup>

<!--Imports must be after PropertyGroup block-->
<!--Only import Mod.props for reference resolution, skip Mod.targets to avoid ModPostProcessor issues with .NET 8-->
Copy link

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out the Mod.targets import may cause build functionality loss beyond just ModPostProcessor. The comment should clarify what build steps/targets are being skipped and document any manual workarounds required (e.g., missing MSBuild tasks for PDX publishing, deployment steps). Consider whether critical build targets from Mod.targets need to be manually replicated.

Suggested change
<!--Only import Mod.props for reference resolution, skip Mod.targets to avoid ModPostProcessor issues with .NET 8-->
<!--
Only import Mod.props for reference resolution.
Mod.targets is NOT imported to avoid ModPostProcessor issues with .NET 8.
By skipping Mod.targets, the following build steps/targets are NOT run:
- ModPostProcessor (custom post-build step, incompatible with .NET 8)
- PDX publishing/deployment MSBuild targets (e.g., tasks for packaging and uploading to Paradox Mods)
- Any other custom build steps defined in Mod.targets
Manual workarounds required:
- If publishing to Paradox Mods, use the Paradox launcher or upload manually.
- Deployment: Copy output DLLs to the mod folder manually as needed.
- If any other build steps from Mod.targets are required, replicate them manually in this .csproj.
Re-enable the Mod.targets import ONLY if all targets are compatible with .NET 8.
-->

Copilot uses AI. Check for mistakes.
<Import Project="$([System.Environment]::GetEnvironmentVariable('CSII_TOOLPATH', 'EnvironmentVariableTarget.User'))\Mod.props" />
<Import Project="$([System.Environment]::GetEnvironmentVariable('CSII_TOOLPATH', 'EnvironmentVariableTarget.User'))\Mod.targets" />
<!--<Import Project="$([System.Environment]::GetEnvironmentVariable('CSII_TOOLPATH', 'EnvironmentVariableTarget.User'))\Mod.targets" />-->

<!--Override Mod.props settings to use .NET 8 instead of net48-->
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>latest</LangVersion>
<GenerateDependencyFile>false</GenerateDependencyFile>
<!--Skip ModPostProcessor which may not be compatible with .NET 8-->
Copy link

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment states ModPostProcessor 'may not be compatible' with .NET 8, but this is speculative without concrete evidence. Consider documenting the specific incompatibility encountered (e.g., error message, behavior) or noting this is a preventive measure pending verification of .NET 8 compatibility.

Suggested change
<!--Skip ModPostProcessor which may not be compatible with .NET 8-->
<!--Preventively skip ModPostProcessor: .NET 8 compatibility has not been verified as of this release. If you encounter issues, please document the specific error here.-->

Copilot uses AI. Check for mistakes.
<RunModPostProcessor>false</RunModPostProcessor>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion InfiniteDemand/Library/ilpp.pid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
13112
17400
2 changes: 1 addition & 1 deletion InfiniteDemand/Properties/PublishConfiguration.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@ Built with .NET 8 for optimal performance and compatibility with the latest game
<!--ChangeLog>
</ChangeLog-->
<!--External link. supported types are discord, github, youtube, twitch, x, paypal, patreon-->
<ExternalLink Type="github" Url="https://github.com/johnytoxic/CSL2DemandControl/tree/main/InfiniteDemand" />
<ExternalLink Type="github" Url="https://github.com/ChengBoChuan/demand_modifier/tree/master/InfiniteDemand" />
</Publish>