Rigid shear fixes (github: trishakholiya)#1
Open
trishakholiya wants to merge 2 commits intoChem281Materials:developfrom
Open
Rigid shear fixes (github: trishakholiya)#1trishakholiya wants to merge 2 commits intoChem281Materials:developfrom
trishakholiya wants to merge 2 commits intoChem281Materials:developfrom
Conversation
1. indexing bug fix for ghost comm of remapped velocities across PBC when group all is not used 2. velocity remapping of rigid body VCM 3. Langevin corrections for rigid bodies in shear 4. port ghost atom velocity bugfix to KOKKOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request rebases the rigid-shear branch onto develop, squashing the branch changes into a single commit.
These updates include:
This also includes a commit from the maintenance branch that adds missing override.
Related Issue(s)
None
Author(s)
GitHub Actions done by Trisha Kholiya
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
Implementation Notes
Changes implemented based on HW assignment.
Post Submission Checklist
Further Information, Files, and Links
HW 2-2