Conversation
cx-elchanan-arbiv
requested review from
cx-ben-alvo,
cx-daniel-greenspan and
cx-miryam-foifer
as code owners
|
Great job, no security vulnerabilities found in this Pull Request |
| const radioButtons = await webView.findWebElements(By.css("input[type='radio']")); | ||
| console.log(`Found ${radioButtons.length} radio buttons`); | ||
|
|
||
| // Additional test code... |
There was a problem hiding this comment.
where is the test code?
what exactly are we testing here?
There was a problem hiding this comment.
It tests the logout button, meaning it clicks on it and then clicks "yes" in the dialog message that appears.
Additionally, after logging out, it checks that there are two buttons:
There was a problem hiding this comment.
I added to the test that if the user wasn't logged in, it should first log in and then perform a logout to test this process.
The test also verifies the fields for both OAuth and API Key authentication methods.
| await new EditorView().closeAllEditors(); | ||
| }); | ||
|
|
||
| it("should open OAuth authentication panel and verify UI elements", retryTest(async function () { |
There was a problem hiding this comment.
refactor this test and extract code to separate function in order to make it shorter and more readble.
You also have some duplicate code that you can extract into separate function.
example for duplicated code:
await new EditorView().closeAllEditors();
await bench.executeCommand(CX_AUTHENTICATION_COMMAND);
await sleep(3000);
await new EditorView().openEditor("Checkmarx One Authentication");
await webView.switchToFrame(5000);
There was a problem hiding this comment.
i Split into multiple tests and manage the duplicate code
3 participants
Description
References
Testing
Checklist