Skip to content
This repository was archived by the owner on Jan 6, 2026. It is now read-only.

feat: support on-demand retrieval tasks without affecting RSR scoring#134

Closed
Hany-Almnaem wants to merge 7 commits intoCheckerNetwork:mainfrom
Hany-Almnaem:feature/on-demand-checks
Closed

feat: support on-demand retrieval tasks without affecting RSR scoring#134
Hany-Almnaem wants to merge 7 commits intoCheckerNetwork:mainfrom
Hany-Almnaem:feature/on-demand-checks

Conversation

@Hany-Almnaem
Copy link
Contributor

Summary

This PR adds support for on-demand retrieval tasks in Spark Checker, allowing storage providers (SPs) or developers to request ad-hoc checks for debugging or configuration validation — without affecting RSR scoring.

Implements: #103 – Allow SP to request more frequent checks


What’s Included

Core Logic

  • tasker.js

    • Added queueOnDemandTask() and a private #onDemandTasks queue
    • Updated next() to prioritize on-demand tasks
    • Tagged tasks with isOnDemand: true
  • spark.js

    • submitMeasurement() includes excludeFromRSR: true when submitting on-demand tasks

Test

  • tasker.test.js: Verifies that on-demand tasks are returned before round tasks
  • spark.test.js: Confirms excludeFromRSR is included in the measurement payload when isOnDemand is set

Manual Testing Script

  • scripts/trigger-on-demand.js
    • Demonstrates how to queue an on-demand task manually

Notes

  • No HTTP endpoint was added. This should be considered separately to ensure secure access and abuse prevention.
  • All changes are backward-compatible

Let me know if any adjustments are needed .

@bajtos
Copy link
Member

bajtos commented Jun 3, 2025

Hi @Hany-Almnaem, we appreciate the effort you put into this pull request. Unfortunately, we are not interested in accepting this feature right now (and maintaining it ourselves going forward).

@bajtos bajtos closed this Jun 3, 2025
@github-project-automation github-project-automation bot moved this to ✅ done in CheckerNetwork Jun 3, 2025
@Hany-Almnaem Hany-Almnaem deleted the feature/on-demand-checks branch June 3, 2025 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: ✅ done

Development

Successfully merging this pull request may close these issues.

2 participants