This repository was archived by the owner on Jan 6, 2026. It is now read-only.
feat: support on-demand retrieval tasks without affecting RSR scoring#134
Closed
Hany-Almnaem wants to merge 7 commits intoCheckerNetwork:mainfrom
Closed
feat: support on-demand retrieval tasks without affecting RSR scoring#134Hany-Almnaem wants to merge 7 commits intoCheckerNetwork:mainfrom
Hany-Almnaem wants to merge 7 commits intoCheckerNetwork:mainfrom
Conversation
Member
|
Hi @Hany-Almnaem, we appreciate the effort you put into this pull request. Unfortunately, we are not interested in accepting this feature right now (and maintaining it ourselves going forward). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for on-demand retrieval tasks in Spark Checker, allowing storage providers (SPs) or developers to request ad-hoc checks for debugging or configuration validation — without affecting RSR scoring.
Implements: #103 – Allow SP to request more frequent checks
What’s Included
Core Logic
tasker.jsqueueOnDemandTask()and a private#onDemandTasksqueuenext()to prioritize on-demand tasksisOnDemand: truespark.jssubmitMeasurement()includesexcludeFromRSR: truewhen submitting on-demand tasksTest
tasker.test.js: Verifies that on-demand tasks are returned before round tasksspark.test.js: ConfirmsexcludeFromRSRis included in the measurement payload whenisOnDemandis setManual Testing Script
scripts/trigger-on-demand.jsNotes
Let me know if any adjustments are needed .