[25.01.28 / TASK-271] Hotfix - recentPosts에서 viewDiff 제거#51
Conversation
WalkthroughgetUserRecentPosts의 Changes
Sequence Diagram(s)(생성 조건 미충족 — 생략) Estimated code review effort🎯 3 (중간) | ⏱️ ~20분 Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/services/totalStats.service.ts`:
- Around line 72-74: The call that assigns recentPosts is passing
BADGE_DATE_RANGE (30) as the limit to getUserRecentPosts which causes 30 items
to be returned; update the call in totalStats.service.ts (the recentPosts
assignment / the getUserRecentPosts invocation used when type === 'default') to
use the intended recent-post limit (e.g. introduce or use RECENT_POSTS_LIMIT =
4) or omit the stray date-range constant so getUserRecentPosts receives the
correct 4-item limit instead of BADGE_DATE_RANGE; ensure you reference and/or
add the RECENT_POSTS_LIMIT constant and pass that into getUserRecentPosts (or
rely on its default) rather than BADGE_DATE_RANGE.
Nuung
left a comment
There was a problem hiding this comment.
거의 다 코드를 빼는거라 특별하게 리뷰할 포인트가 없긴 하네요! 코멘트만 체크해 주세요.
궁금한건 view diff 를 빼면 CTE 를 포함해 sql query 가 좀 줄어들 줄 알았는데 생각보다 거의 차이가 없네요?!
ooheunda
left a comment
There was a problem hiding this comment.
변경사항 확인했습니다! 고생하셨습니다~! 🔥👍
기존에 CTE를 별도 블록으로 빼두셔서 이번 수정사항을 따라가기가 더 쉬웠던 것 같아요.
현재는 최근 게시물의 증가폭만 제거한 상태입니다. user 전체 통계의 증가폭도 필요가 없어진다면, sql query가 더 줄어들 것 같습니다! |
six-standard
left a comment
There was a problem hiding this comment.
리뷰가 생각보다 너무 늦어졌네요.. 죄송합니다
다른 분들이 리뷰해주신 부분 제외하고 큰 문제는 없는 것 같고, 생각보다 줄어든 양이 좀 적어서 놀랍네요
🔥 변경 사항
🏷 관련 이슈
#123📸 스크린샷 (UI 변경 시 필수)
(변경 사항이 UI와 관련된 경우 스크린샷을 첨부해주세요.)
📌 체크리스트
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.