Refactored the ASM patch system #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up ASMConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored the asm patcher system to make it easier to write patches as well as make it cleaner overall. Annotated classes with annotated static functions have replaced the use of IPatchManager and IPatch thingys (see classes in
com.charles445.rltweaker.asm.patch). RLTweakerASM as passed as an extra argument to each patch function for future logging support (TODO: replace the System.out.println() statements). I know this feels at first like I have fixed something that is not broken, but have a look around and I think you will like it.There might be some formatting concerns. Let me know if you want it to strictly adhere to the format that you use.