add setDirectory function #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey, thanks for the pull request, its good idea. Since there is currently terminal does not have a setStartDirectory function most people will probably use this command to change the default directory the terminal is started in. This is a bit problematic, since the terminal takes some time to start and causes the command to generate duplicate entries on start up.
Furthermore we cannot simply call commands like "clear" afterwards since some terminals provide start up information. So we would need to solve this first. Also please move the function below the signal function e.g. the updateTerminal function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setDirectory function opens terminal in a specified folder (just a cd command)