Add support for KHR_materials_emissive_strength, KHR_materials_ior.#21
Open
jasondavies wants to merge 3 commits intoChaosGroup:mainfrom
Open
Add support for KHR_materials_emissive_strength, KHR_materials_ior.#21jasondavies wants to merge 3 commits intoChaosGroup:mainfrom
jasondavies wants to merge 3 commits intoChaosGroup:mainfrom
Conversation
jasondavies
force-pushed
the
khr_material_emissive_strength
branch
from
a85f252 to
ca4410a
Compare
jasondavies
changed the title
This also fixes support for emissive factor without emissive texture. Fixes ChaosGroup#14, ChaosGroup#15.
jasondavies
force-pushed
the
khr_material_emissive_strength
branch
from
e993c58 to
f3fe411
Compare
Contributor
Author
|
The I suspect there's still some work to be done before This is ready for review/merge; the other extensions can be done in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes support for emissive factor without emissive texture.
Fixes #14.