Pr1 done #10
Open
Pr1 done #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xSAVIKx
requested changes
Dec 12, 2016
Member
xSAVIKx
left a comment
xSAVIKx
left a comment
There was a problem hiding this comment.
Please update your code to pass all the tests.
| int result = 0; | ||
| for (int i = 0; i < a.length(); i++) { | ||
| if (a.charAt(i) != a1.charAt(i)) { | ||
| return result++; |
Member
There was a problem hiding this comment.
for sure, you shouldn't return result here, you should only increment it here.
|
|
||
| } | ||
|
|
||
| private static void makeChoice () { |
Member
There was a problem hiding this comment.
This function should be renamed, as it don't really "make any choice", it just prints your "help" or "menu" messages.
| if (input.equals("help")) { | ||
| makeChoice(); | ||
| scanner.next(); | ||
| } |
Member
There was a problem hiding this comment.
I personally don't like such solution, where you move some switch clauses into separate if-else statements, I'd really prefer some other implementation where all possible commands would be inside one switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.