Task1-10 Vynnyk #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didva
reviewed
Nov 21, 2016
| public static double getSumOfGreatest(double a, double b, double c) { | ||
| return 0; | ||
|
|
||
| double firstMax; |
There was a problem hiding this comment.
It's too complicated.
You can go from the back side, find the smallest number in one if statement and return summ of the others.
| public class Task3 { | ||
| public static boolean isBetween(int a, int b, int c) { | ||
| return false; | ||
| if (a==b||b==c){return true;} |
There was a problem hiding this comment.
You can use <=, >= operators instead of this condition.
| public class Task5 { | ||
| public static double calculateA(double x, double y, double z) { | ||
| return 0; | ||
| double b = 1+((Math.pow(z,2)))/(3+(Math.pow(z,2)/5)); |
There was a problem hiding this comment.
The idea was to use smth like double b = calculateB(z) , but it's ok for now.
There was a problem hiding this comment.
It most case it's better to extract duplicated calculations into variable. So, please extract Math.pow(z, 2).
| public static double calculateS(double x) { | ||
| return 0d; | ||
|
|
||
| double s=1+x+(Math.pow(x,2)/(2*1))+(Math.pow(x,3)/(3*2*1))+(Math.pow(x,4)/(4*3*2*1)); |
|
|
||
| public static double calculateZ(double x, double y) { | ||
| return 0d; | ||
| double z=Math.sin(Math.pow(x,3))+Math.pow(Math.cos(y),2); |
| double sum=0; | ||
| for (int i = 0; i <= N; i++) { | ||
|
|
||
| b = Math.pow(N + i, 2); |
|
|
||
| public static boolean isPowerOfThree(int n) { | ||
| if (n==1){return true;} | ||
| if (n==0){return false;} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.