Skip to content

[Revised] New Component: NumberInput #30#40

Merged
kohrachel merged 5 commits intomainfrom
NumberInput
Dec 1, 2025
Merged

[Revised] New Component: NumberInput #30#40
kohrachel merged 5 commits intomainfrom
NumberInput

Conversation

@JKong05
Copy link
Collaborator

@JKong05 JKong05 commented Nov 16, 2025

Following up with some changes to NumberInput component.

  • Removed handleBlur() and base()
  • Preserved val as a number and removed extra string state
  • Directly calls setVal() inside increment and decrement handlers
  • Removed unneeded input keydown controls (Up, Down, Escape) inside handleKeyDown()
  • Only using === now
  • Sets max, min, and step locally now
  • Using Google Icons now in button styling
  • In handleChange(), invalid numeric inputs are now handled
Screenshot 2025-11-15 at 8 05 58 PM

Copy link
Contributor

@kohrachel kohrachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for coding this up :)

I just realized that the Figma uses Material Symbols Rounded instead of Outlined so I changed that for standardization. Great work 💪🏻💪🏻💪🏻

@kohrachel kohrachel merged commit 0024717 into main Dec 1, 2025
3 checks passed
@kohrachel kohrachel deleted the NumberInput branch December 1, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments