Conversation
kohrachel
approved these changes
Nov 30, 2025
Contributor
kohrachel
left a comment
There was a problem hiding this comment.
Looks good! Thanks for coding this up :)
I just realized that the Figma uses Material Symbols Rounded instead of Outlined so I changed that for standardization. Great work 💪🏻💪🏻💪🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up with some changes to NumberInput component.
handleBlur()andbase()valas a number and removed extra string statesetVal()inside increment and decrement handlershandleKeyDown()===nowmax,min, andsteplocally nowhandleChange(), invalid numeric inputs are now handled