Conversation
Closed
kohrachel
reviewed
Nov 30, 2025
Contributor
kohrachel
left a comment
kohrachel
left a comment
There was a problem hiding this comment.
Looks good!
We should be good to merge in the PRs for and today. Could you finish implementing the with those two? It should be relatively straightforward since you've structured it really well, lmk if you run into any problems though :)
Also my bad on icons we're actually using Google's Material Symbols Rounded icons, I updated the code to use that (it relies on a tag in the root layout.tsx, so you might have to pull from main after this to get the icons to render). The lucide dependency will be removed soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating SearchBar component. Once Button and TextInput are fully implemented, SearchBar should extend those components, but for now, we use custom button/textinput.
Example SearchBar component