Added back to top button #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for asc-hirehub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Author
|
#7 |
ChandelAnish
reviewed
Oct 4, 2024
Owner
ChandelAnish
left a comment
ChandelAnish
left a comment
There was a problem hiding this comment.
implement dark mode for every elements there are many elements , images not fallowing the dark theme and also the footer text in not readable due to dark color
and also the dark mode toggle is not matching the theme make it some what like this :
Author
|
Could you please first merge the #22 pr because it is creating confusion for me to update as its showing commit ahead. |
Author
|
fixed the dark mode |
ChandelAnish
reviewed
Oct 5, 2024
Author
|
[image: image.png][image: image.png]
fixed all the issues
…On Sun, 6 Oct 2024 at 03:46, Anish Singh Chandel ***@***.***> wrote:
***@***.**** commented on this pull request.
just place the toggle button in the nav bar no need to make it sticky
image.png (view on web)
<https://github.com/user-attachments/assets/297bbc49-16b9-43d8-8db3-77b786032d5b>
the text is not readable , you should remove the background of the
background image or use different image with same context
image.png (view on web)
<https://github.com/user-attachments/assets/5c98509f-03d7-4cb9-bbed-b908bba325ec>
make the navbar in dark theme too
image.png (view on web)
<https://github.com/user-attachments/assets/06c3ebb2-2cf6-4f4e-ab59-3126f7e2c243>
—
Reply to this email directly, view it on GitHub
<#54 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BH2GHYD3SPN2JE7SNCUVB63Z2BQM7AVCNFSM6AAAAABPLOYJ3GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNJQGQYDIMZVGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
|
Author
|
Please assign with labels |
Owner
ChandelAnish
left a comment
ChandelAnish
left a comment
There was a problem hiding this comment.
you removed the image from here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22
Created a "Back to Top" button that is fixed to the bottom right corner of the page. When clicked, it smoothly scrolls the user back to the top of the page.
Please assign the gssoc and hactoberfest labels.
Also please give level2 tag.